Skip to content

Commit 7dfbdc4

Browse files
committed
rebase: avoid using the comma operator unnecessarily
The comma operator is a somewhat obscure C feature that is often used by mistake and can even cause unintentional code flow. Better use a semicolon instead. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent e3069fd commit 7dfbdc4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

builtin/rebase.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1843,7 +1843,7 @@ int cmd_rebase(int argc,
18431843
strbuf_addf(&msg, "%s (start): checkout %s",
18441844
options.reflog_action, options.onto_name);
18451845
ropts.oid = &options.onto->object.oid;
1846-
ropts.orig_head = &options.orig_head->object.oid,
1846+
ropts.orig_head = &options.orig_head->object.oid;
18471847
ropts.flags = RESET_HEAD_DETACH | RESET_ORIG_HEAD |
18481848
RESET_HEAD_RUN_POST_CHECKOUT_HOOK;
18491849
ropts.head_msg = msg.buf;

0 commit comments

Comments
 (0)