Skip to content

Commit 3680457

Browse files
authored
Merge pull request #35 from dsdude123/new-player-fixes
Update GroovyRP to support new Media Player, disable auto start support.
2 parents 2df5bed + 3254601 commit 3680457

3 files changed

Lines changed: 23 additions & 16 deletions

File tree

GroovyRPCore/GrooveInfoFetcher.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public TrackInfo GetTrackInfo()
2626

2727
public bool IsUsingAudio()
2828
{
29-
var grooveMusics = Process.GetProcessesByName("Music.UI");
29+
var grooveMusics = Process.GetProcessesByName("Microsoft.Media.Player");
3030
if (grooveMusics.Any())
3131
{
3232
AudioSessionManager2 sessionManager;
@@ -46,7 +46,7 @@ public bool IsUsingAudio()
4646
using (var sessionControl = session.QueryInterface<AudioSessionControl2>())
4747
{
4848
var process = sessionControl.Process;
49-
if (process != null && process.ProcessName.Equals("Music.UI"))
49+
if (process != null && process.ProcessName.Equals("Microsoft.Media.Player"))
5050
{
5151
targetProcess = true;
5252
}

GroovyRPHelper/Program.cs

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ private static void RegisterTask()
140140
startupTrigger.Subscription = @"
141141
<QueryList>
142142
<Query Id='0' Path='Application'>
143-
<Select Path='Application'>Event[System[Provider[@Name='ESENT'] and (Level=4 or Level=0) and (EventID=102)] and EventData[Data='Music.UI']]</Select>
143+
<Select Path='Application'>Event[System[Provider[@Name='ESENT'] and (Level=4 or Level=0) and (EventID=102)] and EventData[Data='Microsoft.Media.Player']]</Select>
144144
</Query>
145145
</QueryList>
146146
";
@@ -167,17 +167,24 @@ private static void UnregisterTask()
167167
private static Config CreateConfiguration()
168168
{
169169
Config config = new Config();
170-
DialogResult autoStartChoice = MessageBox.Show("Do you want to automatically start GroovyRP when Groove Music is opened?", "First Run Setup", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
171-
if (autoStartChoice.Equals(DialogResult.Yes))
172-
{
173-
RegisterTask();
174-
config.RunWhenGrooveMusicOpens = true;
175-
}
176-
else
177-
{
178-
UnregisterTask();
179-
config.RunWhenGrooveMusicOpens = false;
180-
}
170+
171+
/*
172+
* The new media player no longer generates events needed to auto start GrovvyRP.
173+
* Unfortinutely have no choice but to disable auto start support for now.
174+
*/
175+
UnregisterTask();
176+
config.RunWhenGrooveMusicOpens = false;
177+
//DialogResult autoStartChoice = MessageBox.Show("Do you want to automatically start GroovyRP when Groove Music is opened?", "First Run Setup", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
178+
//if (autoStartChoice.Equals(DialogResult.Yes))
179+
//{
180+
// RegisterTask();
181+
// config.RunWhenGrooveMusicOpens = true;
182+
//}
183+
//else
184+
//{
185+
// UnregisterTask();
186+
// config.RunWhenGrooveMusicOpens = false;
187+
//}
181188

182189
DialogResult hideChoice = MessageBox.Show("Do you want to run GroovyRP in the background when it is opened?", "First Run Setup", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
183190
if (hideChoice.Equals(DialogResult.Yes))
@@ -240,7 +247,7 @@ private static void UpdateCheck(object Sender, EventArgs e)
240247

241248
public static void checkGrooveMusicStatus()
242249
{
243-
Process[] grooveMusics = Process.GetProcessesByName("Music.UI");
250+
Process[] grooveMusics = Process.GetProcessesByName("Microsoft.Media.Player");
244251
if (grooveMusics.Length < 1)
245252
{
246253
Environment.Exit(0);

VersionInfo.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<VersionInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
3-
<Version>1.0.0.0</Version>
3+
<Version>1.1.0.0</Version>
44
</VersionInfo>

0 commit comments

Comments
 (0)