Skip to content

Commit eb7fde7

Browse files
authored
Fix failing test cases on Mac (OpenLiberty#570)
* Update transitive dependencies * Rename test project directories * Fix InputBox issue on Mac and reformat util files * Add settings.json for tests * Update Maven project test logging and reformat Maven test files * Reformat test util files * Reformat Gradle test files * Update logging in Gradle tests * Update macOS version used in GHA * Add test logger to fix interleaved messages * Refactor test logger to remove buffering and use stderr * Update test logger to write synchronously * Simplify test logger * Update INFO and ERROR spacing * Update test log formatting * Remove unnecessary click() call causing Mac test failures * Update wait time for dashboard loading * Add screenshot archiving to Gradle tests, move logic to testUtils * Separate Maven and Gradle test workflows * Update test workflow names * Update vscode-extension-tester to latest * Remove redundant sections in exec.sh * Fix display start for Gradle * Add initial wait before checking for Liberty dashboard in sidebar * Increase timeout for sidebar detection test * Update test steps to use smarter waits * Update tests to fetch dashboard per test to avoid cascading failures * Update Liberty sidebar item lookup * Close surefire report in Maven tests * Copyright updates
1 parent 82cb2bb commit eb7fde7

39 files changed

Lines changed: 2745 additions & 1972 deletions

File tree

.github/workflows/run-regression-tests.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,20 @@ jobs:
1414
runtime: [ linux, mac ]
1515
# Removing windows as a standard run flavor runtime: [ linux, mac, windows ]
1616
targetVSCode: [previous, latest ]
17+
buildTool: [maven, gradle]
1718
# As Vscode 1.79 and 1.78 are the only support version for current release, running test with only latest,previous
1819
#Enable it in future for multiple releases as applicable targetVSCode: [ previousMinusOne, previous, latest ]
1920
include:
2021
- runtime: linux
2122
os: ubuntu-latest
2223

2324
- runtime: mac
24-
os: macOS-13
25+
os: macOS-15
2526

2627
# - runtime: windows
2728
# os: windows-latest
2829

29-
name: Build Plugin
30+
name: Test ${{ matrix.runtime }} - ${{ matrix.buildTool }} - ${{ matrix.targetVSCode }}
3031
runs-on: ${{ matrix.os }}
3132

3233
steps:
@@ -44,24 +45,24 @@ jobs:
4445

4546
# Archive artifacts
4647
- name: Archive artifacts
47-
if: runner.os == 'linux' && matrix.targetVSCode == 'latest'
48+
if: runner.os == 'linux' && matrix.targetVSCode == 'latest' && matrix.buildTool == 'maven'
4849
uses: actions/upload-artifact@v4.3.4
4950
with:
5051
name: liberty-tools-vscode-${{ github.sha }}
5152
path: ./**/*.vsix
5253
if-no-files-found: warn
5354
retention-days: 7
5455

55-
# Build the plugin.
56-
- name: 'Test: RunTests'
57-
run: bash ./src/test/resources/ci/scripts/exec.sh TEST ${{ matrix.targetVSCode }}
56+
# Run tests for specific build tool
57+
- name: 'Test: Run ${{ matrix.buildTool }} Tests'
58+
run: bash ./src/test/resources/ci/scripts/exec.sh TEST ${{ matrix.targetVSCode }} ${{ matrix.buildTool }}
5859

5960
# Archive screenshots
6061
- name: Archive screenshots
6162
if: always()
6263
uses: actions/upload-artifact@v4.3.4
6364
with:
64-
name: liberty-run-tests-screenshots-${{ runner.os }}-${{ matrix.targetVSCode }}
65-
path: ./screenshots/*.png
65+
name: liberty-tools-vscode-${{ matrix.runtime }}-${{ matrix.buildTool }}-${{ matrix.targetVSCode }}-tests-screenshots
66+
path: ./screenshots/${{ matrix.buildTool }}/*.png
6667
if-no-files-found: warn
6768
retention-days: 7

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@ target/
1010
build/
1111
.gradle/
1212
bin/
13+
**/screenshots
14+
**/test-tools

0 commit comments

Comments
 (0)