1.3.1 remove fixed codes

Author: hyungit

README.md

@@ -128,9 +128,7 @@ scope.launch {
     - Retry on Error
         - `Resource` contains `retry()`
         - Default error ui(snackbar) shows retry button and user can retry by the button without additional implementation
-- This provides common functions on ViewModel and Screen
-    - `goBack()` : You can return response, it's explained on [Navigate to the deeplink from Client / Server](https://github.com/dss99911/kotlin-simple-architecture#navigate-to-the-deeplink-from-client--server)
-    - `navigateToDeeplink()`
+- This provides common functions on ViewModel
     - `loadInIdle()` : For example, in case of clicking button two times quickly. 2nd time click is ignored.
     - `loadBounce()` : For example, searching with keyword. and if searching takes time(like api call is required), in that case, delay the api call and if next input comes, cancel previous call
 

buildSrc/src/main/kotlin/Dependencies.kt

@@ -102,7 +102,6 @@ object deps {
         val pluginApiNative = depSimpleArchitecture("gradle-plugin-api-native", versions.simpleArch)
         val pluginGradle = depSimpleArchitecture("gradle-plugin", versions.simpleArch)
         val annotation = depSimpleArchitecture("annotation", versions.simpleArch)
-        val annotationJvm = depSimpleArchitecture("annotation-jvm", versions.simpleArch)
     }
 
     object plugin {

buildSrc/src/main/kotlin/DependencyVersion.kt

@@ -1,5 +1,5 @@
 object versions {
-    const val simpleArch = "1.3.0"
+    const val simpleArch = "1.3.1"
 
     object kotlin {
         const val version = "1.4.20"

gradle-plugin/kotlin-simple-architecture-gradle-plugin-api-shared/build.gradle.kts

@@ -21,8 +21,7 @@ dependencies {
     compileOnly(deps.plugin.compilerEmbeddable)
     compileOnly(deps.plugin.auto)
     kapt(deps.plugin.auto)
-    // todo this is not working as it's multiplatform. check the reason and solve
-//    api(deps.simpleArch.annotationJvm)
+    api(deps.simpleArch.annotation)
 }
 
 publishJvm()

gradle-plugin/kotlin-simple-architecture-gradle-plugin-api-shared/src/main/kotlin/kim/jeonghyeon/simplearchitecture/plugin/external/Api.kt

@@ -1,5 +1,4 @@
 plugins {
-    id("com.android.library")
     kotlin("multiplatform")
 }
 
@@ -11,23 +10,9 @@ kotlin {
 
     //if this multiplatform doesn't include any platform that your project is using, then your project won't recognize this library
     jvm()
-    js().browser()
+    js()/*.browser()*/
 
     ios()
-    //todo is this required? try to remove
-    android {
-        publishLibraryVariants("release", "debug")
-    }
-}
-
-android {
-    compileSdkVersion(config.compileSdkVersion)
-    buildToolsVersion(config.buildToolVersion)
-    defaultConfig {
-        minSdkVersion(config.minSdkVersion)
-        targetSdkVersion(config.targetSdkVersion)
-
-    }
 }
 
 publishMPP()

gradle-plugin/kotlin-simple-architecture-gradle-plugin-api-shared/src/main/kotlin/kim/jeonghyeon/simplearchitecture/plugin/external/ApiParameterType.kt

@@ -55,8 +55,7 @@ kotlin {
                 api(deps.ktor.clientSerialization)
                 api(deps.ktor.clientLogging)
                 api(deps.sqldelight.runtime)
-                //todo this is not working, try after coroutin mt released. https://github.com/cashapp/sqldelight/issues/1917
-                //api(deps.sqldelight.coroutine)
+                api(deps.sqldelight.coroutine)
                 api(deps.simpleArch.annotation)
                 api(deps.ktor.clientAuth)
                 api(deps.krypto)

gradle-plugin/kotlin-simple-architecture-gradle-plugin-api-shared/src/main/kotlin/kim/jeonghyeon/simplearchitecture/plugin/external/Authenticate.kt

@@ -79,21 +79,7 @@ kotlin {
     sourceSets {
         val commonMain by getting {
             dependencies {
-//                api(project(":${deps.simpleArch.common.getArtifactId()}"))
                 api(deps.simpleArch.common)
-
-                  //todo START there is error on android studio sync. after it's fixed, remove this
-                  // it's working fine on template project. check the difference
-                // https://kotlinlang.slack.com/archives/C3PQML5NU/p1598833788027800
-                api(deps.kotlin.coroutineCore)
-                api(deps.kotlin.serializationCore)
-                api(deps.ktor.clientCore)
-                api(deps.ktor.clientSerialization)
-                api(deps.ktor.clientLogging)
-                api(deps.sqldelight.runtime)
-                api(deps.simpleArch.annotation)
-                api(deps.ktor.clientAuth)
-                //todo END there is error on android studio sync. after it's fixed, remove this
             }
         }
         //TODO HYUN [multi-platform2] : consider to change to clientMain. as front end also may be included to here
@@ -107,14 +93,6 @@ kotlin {
 
         val iosMain by getting {
             dependsOn(mobileMain)
-
-            dependencies {
-                //todo START there is error on android studio sync. after it's fixed, remove this
-                // https://kotlinlang.slack.com/archives/C3PQML5NU/p1598833788027800
-                implementation(deps.sqldelight.native)
-                implementation(deps.ktor.clientIos)
-                //todo END there is error on android studio sync. after it's fixed, remove this
-            }
         }
     }