Skip to content

Commit 2ab712e

Browse files
committed
fix(nccl): fix stream argument passing to CUDA functions
1 parent b7f1ebc commit 2ab712e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/KokkosComm/nccl/req.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ class Req<Experimental::Nccl> {
7070

7171
friend void wait(Req<Experimental::Nccl> &req);
7272
friend void wait_all(std::span<Req<Experimental::Nccl>> reqs);
73-
friend int wait_any(std::span<Req<Experimental::Nccl>> reqs);
73+
friend void wait_any(std::span<Req<Experimental::Nccl>> reqs);
7474
};
7575

7676
inline auto wait(Req<Experimental::Nccl> &req) -> void {
77-
cudaStreamSynchronize(&req.get_inner());
77+
cudaStreamSynchronize(req.get_inner());
7878
for (auto &f : req.record_->postWaits_) {
7979
f();
8080
}
@@ -92,7 +92,7 @@ inline auto wait_any(std::span<Req<Experimental::Nccl>> reqs) -> void {
9292
// Loop while we don't have at least one completed request.
9393
while (completed == 0) {
9494
for (Req<Experimental::Nccl> &req : reqs) {
95-
auto res = cudaStreamQuery(&req.get_inner());
95+
auto res = cudaStreamQuery(req.get_inner());
9696

9797
// If the current request has completed, we must make sure the post-wait callbacks run and are cleared.
9898
// Calling `wait` should be a no-op if the request has no callback to execute.

0 commit comments

Comments
 (0)