[DHT] Change clear record to use zero chunks and correct null format type

Author: AmirAbrams

src/dht/dataheader.h

@@ -122,7 +122,7 @@ class CRecordHeader
         return *this;
     }
 
-    inline bool IsNull() const { return (nFormat == 7); }
+    inline bool IsNull() const { return (nFormat == DHT::DataFormat::Null); }
     void Serialize(std::vector<unsigned char>& vchData);
     bool UnserializeFromData(const std::vector<unsigned char>& vchData);
 

src/dht/datarecord.cpp

@@ -135,19 +135,12 @@ bool CDataRecord::InitPut()
 
 bool CDataRecord::InitClear()
 {
-    std::string strNullValue = "null";
-    uint16_t nPlacement = 1;
-    std::string strSalt = strOperationCode + ":" + std::to_string(nPlacement);
-    CDataChunk chunk(0, nPlacement, strSalt, strNullValue);
-    vChunks.push_back(chunk);
-
     dataHeader.nVersion = 0; // unencrypted
-    dataHeader.nTimeStamp = 0;
     dataHeader.nExpireTime = 0;
-    dataHeader.nChunks = 1;
-    dataHeader.nChunkSize = 4;
-    dataHeader.nDataSize = 4;
-    dataHeader.nFormat = DHT::DataFormat::String;
+    dataHeader.nChunks = 0;
+    dataHeader.nChunkSize = 0;
+    dataHeader.nDataSize = 0;
+    dataHeader.nFormat = DHT::DataFormat::Null;
     dataHeader.nIndexLocation = 0;
     dataHeader.nTimeStamp = GetTime();
     return true;

src/dht/session.cpp

@@ -687,6 +687,7 @@ bool CHashTableSession::SubmitGetRecord(const std::array<char, 32>& public_key,
     // if header matches previous entry, only get missing chunks.
     if (strHeaderHex == "")
         return false; // Header failed, so don't try to get the rest of the record.
+
     nHeaderSeq = iSequence;
     header.LoadHex(strHeaderHex);
     if (!header.IsNull() && header.nChunks > 0) {
@@ -711,6 +712,12 @@ bool CHashTableSession::SubmitGetRecord(const std::array<char, 32>& public_key,
         nGetBytes += header.nDataSize;
         record = getRecord;
         return true;
+    } else if (header.IsNull()) {
+        std::vector<CDataChunk> vChunks;
+        CDataRecord getRecord(strOperationType, 0, header, vChunks, Array32ToVector(private_seed));
+        record = getRecord;
+        nGetBytes += header.nDataSize;
+        return true;
     }
     return false;
 }