Merge pull request #4112 from dubinc/soft-delete-codes

Add `isSoftDelete` prop to `deleteDiscountCodes`

Author: steven-tey

…/api/cron/discount-codes/delete/route.ts …api/cron/discount-codes/disable/route.tsapps/web/app/(ee)/api/cron/discount-codes/delete/route.ts renamed to apps/web/app/(ee)/api/cron/discount-codes/disable/route.ts apps/web/app/(ee)/api/cron/discount-codes/delete/route.ts renamed to apps/web/app/(ee)/api/cron/discount-codes/disable/route.ts

@@ -14,7 +14,7 @@ const inputSchema = z.object({
   provider: z.enum(DiscountProvider),
 });
 
-// POST /api/cron/discount-codes/delete
+// POST /api/cron/discount-codes/disable – disable a discount code from the provider (Stripe, Shopify, etc.)
 export const POST = withCron(async ({ rawBody }) => {
   const { provider, code, programId } = inputSchema.parse(JSON.parse(rawBody));
 

apps/web/app/(ee)/api/cron/partners/ban/route.ts

@@ -138,7 +138,7 @@ export const POST = withCron(async ({ rawBody }) => {
     recordLink(links, { deleted: true }),
 
     // Queue discount code deletions
-    deleteDiscountCodes(discountCodes),
+    deleteDiscountCodes(discountCodes, { isSoftDelete: true }),
   ]);
 
   // Send email

apps/web/app/(ee)/api/cron/partners/deactivate/route.ts

@@ -58,7 +58,7 @@ export const POST = withCron(async ({ rawBody }) => {
   const discountCodes = programEnrollments.flatMap(({ discountCodes }) =>
     discountCodes.map((dc) => dc),
   );
-  await deleteDiscountCodes(discountCodes);
+  await deleteDiscountCodes(discountCodes, { isSoftDelete: true });
   console.log("[bulkDeactivatePartners] Queued discount code deletions.");
 
   // Find the program

apps/web/app/(ee)/api/discount-codes/route.ts

@@ -11,6 +11,7 @@ import {
   DiscountCodeSchema,
   getDiscountCodesQuerySchema,
 } from "@/lib/zod/schemas/discount";
+import { APP_DOMAIN } from "@dub/utils";
 import { waitUntil } from "@vercel/functions";
 import { NextResponse } from "next/server";
 
@@ -100,12 +101,15 @@ export const POST = withWorkspace(
             code,
           },
         },
+        include: {
+          partner: true,
+        },
       });
 
       if (duplicateByCode) {
         throw new DubApiError({
-          code: "bad_request",
-          message: `A discount with the code ${code} already exists in the program. Please choose a different code.`,
+          code: "conflict",
+          message: `This discount code "${code}" is already in use by [${duplicateByCode.partner.email}](${APP_DOMAIN}/${workspace.slug}/program/partners/${duplicateByCode.partner.id}). Please choose a different code.`,
         });
       }
     }

apps/web/app/(ee)/api/partner-profile/programs/[programId]/links/route.ts

@@ -37,6 +37,7 @@ export const GET = withPartnerProfile(async ({ partner, params }) => {
     return {
       ...link,
       discountCode: discountCode?.code,
+      discountCodeDisabledAt: discountCode?.disabledAt ?? null,
     };
   });
 

apps/web/app/(ee)/api/stripe/integration/webhook/utils/attribute-via-promotion-code-id.ts

@@ -70,14 +70,21 @@ export async function attributeViaPromotionCodeId({
         code: promotionCode.code,
       },
     },
-    select: {
+    include: {
       link: true,
     },
   });
 
   if (!discountCode) {
     console.log(
-      `Couldn't find link associated with promotion code ${promotionCode.code}, skipping...`,
+      `Couldn't find discount code "${promotionCode.code}" in program "${workspace.defaultProgramId}", skipping...`,
+    );
+    return null;
+  }
+
+  if (discountCode.disabledAt) {
+    console.log(
+      `Discount code "${discountCode.code}" is disabled, skipping...`,
     );
     return null;
   }

apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx

@@ -28,6 +28,7 @@ import {
   getApexDomain,
   getPrettyUrl,
   nFormatter,
+  PARTNERS_DOMAIN,
 } from "@dub/utils";
 import NumberFlow from "@number-flow/react";
 import Link from "next/link";
@@ -75,6 +76,19 @@ export function PartnerLinkCard({ link }: { link: PartnerProfileLinkProps }) {
 
   const isDeactivated = programEnrollment?.status === "deactivated";
 
+  const discountCodeSection = link.discountCode ? (
+    <div className="hidden items-center gap-1.5 rounded-xl border border-neutral-200 py-1 pl-2 pr-1 sm:flex">
+      <span className="text-sm leading-none text-neutral-500">
+        Discount code
+      </span>
+      <DiscountCodeBadge
+        code={link.discountCode}
+        disabledAt={link.discountCodeDisabledAt}
+        disabledTooltip={`This discount code was disabled by the program. [Contact the program owner](${PARTNERS_DOMAIN}/messages/${programEnrollment?.program.slug}) if you need a new code.`}
+      />
+    </div>
+  ) : null;
+
   return (
     <CardList.Card
       innerClassName={cn("px-0 py-0 group/card", isDeactivated && "opacity-80")}
@@ -153,20 +167,14 @@ export function PartnerLinkCard({ link }: { link: PartnerProfileLinkProps }) {
                   </StatusBadge>
                 );
               })()}
-            {link.discountCode && (
-              <Tooltip
-                content={
-                  "This program supports discount code tracking. Copy the code to use it in podcasts, videos, etc. [Learn more](https://dub.co/help/article/dual-sided-incentives)"
-                }
-              >
-                <div className="hidden items-center gap-1.5 rounded-xl border border-neutral-200 py-1 pl-2 pr-1 sm:flex">
-                  <span className="text-sm leading-none text-neutral-500">
-                    Discount code
-                  </span>
-                  <DiscountCodeBadge code={link.discountCode} />
-                </div>
-              </Tooltip>
-            )}
+            {discountCodeSection &&
+              (link.discountCodeDisabledAt ? (
+                discountCodeSection
+              ) : (
+                <Tooltip content="This program supports discount code tracking. Copy the code to use it in podcasts, videos, etc. [Learn more](https://dub.co/help/article/dual-sided-incentives)">
+                  {discountCodeSection}
+                </Tooltip>
+              ))}
             {displayOption === "cards" && <StatsBadge link={link} />}
             <Controls link={link} />
           </div>

apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/page.tsx

@@ -333,7 +333,12 @@ const PartnerDiscountCodes = ({
       {
         id: "code",
         header: "Code",
-        cell: ({ row }) => <DiscountCodeBadge code={row.original.code} />,
+        cell: ({ row }) => (
+          <DiscountCodeBadge
+            code={row.original.code}
+            disabledAt={row.original.disabledAt}
+          />
+        ),
       },
       {
         id: "shortLink",

apps/web/lib/discounts/delete-discount-code.ts

@@ -17,6 +17,7 @@ type DeleteDiscountCodesParams = Pick<
 // 4. When a partner is moved to a different group
 export async function deleteDiscountCodes(
   input: (DeleteDiscountCodesParams | null | undefined)[],
+  { isSoftDelete = false }: { isSoftDelete?: boolean } = {},
 ) {
   const discountCodes = input.filter(
     (dc): dc is NonNullable<typeof dc> => dc != null,
@@ -29,18 +30,36 @@ export async function deleteDiscountCodes(
     return;
   }
 
-  // Delete the discount codes from the database
-  const deletedDiscountCodes = await prisma.discountCode.deleteMany({
-    where: {
-      id: {
-        in: discountCodes.map(({ id }) => id),
+  if (isSoftDelete) {
+    // Soft delete the discount codes from the database (mark them as disabled)
+    const disabledDiscountCodes = await prisma.discountCode.updateMany({
+      where: {
+        id: {
+          in: discountCodes.map(({ id }) => id),
+        },
+      },
+      data: {
+        disabledAt: new Date(),
       },
-    },
-  });
+    });
 
-  console.log(
-    `[deleteDiscountCodes] Deleted ${deletedDiscountCodes.count} discount codes.`,
-  );
+    console.log(
+      `[deleteDiscountCodes] Disabled ${disabledDiscountCodes.count} discount codes.`,
+    );
+  } else {
+    // Delete the discount codes from the database
+    const deletedDiscountCodes = await prisma.discountCode.deleteMany({
+      where: {
+        id: {
+          in: discountCodes.map(({ id }) => id),
+        },
+      },
+    });
+
+    console.log(
+      `[deleteDiscountCodes] Deleted ${deletedDiscountCodes.count} discount codes.`,
+    );
+  }
 
   // Only enqueue external-provider cleanup for codes whose provider is known.
   // Orphaned codes (discount relation is null) still get deleted locally above
@@ -63,7 +82,7 @@ export async function deleteDiscountCodes(
   for (const chunkOfCodes of chunks) {
     await enqueueBatchJobs(
       chunkOfCodes.map((discountCode) => ({
-        url: `${APP_DOMAIN_WITH_NGROK}/api/cron/discount-codes/delete`,
+        url: `${APP_DOMAIN_WITH_NGROK}/api/cron/discount-codes/disable`,
         method: "POST",
         queueName: "delete-discount-code",
         body: {

apps/web/lib/zod/schemas/discount.ts

@@ -62,6 +62,12 @@ export const DiscountCodeSchema = z.object({
   discountId: z.string().nullable(),
   partnerId: z.string(),
   linkId: z.string(),
+  disabledAt: z.coerce
+    .date()
+    .nullish()
+    .describe(
+      "When this discount code was disabled, which happens when a partner is banned or deactivated.",
+    ),
 });
 
 export const createDiscountCodeSchema = z.object({