Partner onboarding: Legal company name input becomes readOnly on validation error, permanently blocking signup

[timscheuerai]

Bug

In the partner onboarding form, the Legal company name input is made readOnly whenever it has a validation error:

// apps/web/app/(ee)/partners.dub.co/(onboarding)/onboarding/onboarding-form.tsx:259
readOnly={!!partner?.companyName || !!errors.companyName}
{...register("companyName", {
  required: profileType === "company",
})}

Since the field is required when profileType === "company", submitting the form with it empty sets errors.companyName, which immediately flips the input to readOnly. The user can no longer type into it, so the error can never be cleared, so Continue can never succeed.

The onboarding form is unrecoverable from that state without a full page reload.

Steps to reproduce

1. Go to partners.dub.co onboarding ("Create your partner profile")
2. Set Profile Type to Company
3. Leave Legal company name empty and click Continue
4. The field now renders with both the red error border and the read-only grey background (read-only:bg-neutral-100 read-only:text-neutral-500), and rejects all input
5. There is no way to proceed. Only a page reload recovers it.

Expected

A required-field validation error should leave the input editable so the user can actually fix it.

Suggested fix

readOnly should only express the "already set, not editable" case:

readOnly={!!partner?.companyName}

Notes

Hit by a real partner signing up to our program. They were fully blocked and assumed the platform was broken. Worth noting the deadlock is easy to fall into, because the natural reading of an empty required field is "click Continue and see what it wants".

[linear]

ENG-1722

[rupesh0001-tech]

Hi @timscheuerai / @steven-tey ! 👋

I've fixed this issue by removing !!errors.companyName from readOnly in onboarding-form.tsx, so the input remains editable after a validation error.

Commit on fork: rupesh0001-tech@e5d490d

Since repository interaction limits currently prevent non-collaborators from opening a PR directly, could you please review the commit above, or grant contributor access so I can submit the PR? Thanks!

[ankit-pandit07]

I’ve prepared a fix for this issue.

The problem was caused by errors.companyName being included in the readOnly condition. After a validation error, the Legal company name field became locked and users could no longer correct it.

I changed the condition so the field is read-only only when an existing partner already has a company name.

Validation completed successfully:

• pnpm build:packages ✅
• pnpm --filter web exec tsc --noEmit ✅
• git diff --check ✅

The fix is available on my fork:
ankit-pandit07/dub
Branch: fix/partner-company-name-readonly

GitHub currently prevents me from opening a PR because PR creation is restricted to repository collaborators.