Show networkStatus badge in PartnerRowItem - #3988

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

apps/web/ui/partners/partner-network/partner-network-status-badge.tsx (1)

34-39: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Still needs fix: Wrap BadgeCheck2Fill in a DOM element for ref forwarding.

The previous review correctly identified that BadgeCheck2Fill doesn't forward refs, which breaks Tooltip's asChild anchoring. This issue remains unresolved.

Reminder of the fix

-        <BadgeCheck2Fill
-          className={cn(
-            "shrink-0 text-blue-500",
-            size === "small" ? "size-3.5" : "size-5",
-          )}
-        />
+        <span className="inline-flex shrink-0">
+          <BadgeCheck2Fill
+            className={cn(
+              "text-blue-500",
+              size === "small" ? "size-3.5" : "size-5",
+            )}
+          />
+        </span>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/ui/partners/partner-network/partner-network-status-badge.tsx` around
lines 34 - 39, Wrap the BadgeCheck2Fill icon in a real DOM element so Tooltip's
asChild can forward refs; specifically, in the partner-network-status-badge
component replace the direct <BadgeCheck2Fill .../> with a <span> (or other
native element) that receives the className used for sizing/positioning and let
the icon keep purely visual classes, e.g., move "shrink-0" and size classes onto
the wrapper so Tooltip (asChild) can attach the ref to the span and
BadgeCheck2Fill remains unchanged.

apps/web/ui/partners/partner-network/partner-network-status-badge.tsx (1)

19-40: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Wrap the Tooltip trigger in a DOM element (BadgeCheck2Fill isn't ref-forwarding).

The Tooltip component uses asChild on its trigger (confirmed in packages/ui/src/tooltip.tsx:77-128), which requires the child to forward refs. However, BadgeCheck2Fill is not implemented with forwardRef (as seen in packages/ui/src/icons/nucleo/badge-check2-fill.tsx:3-20), so tooltip positioning and focus management may fail.

🔧 Proposed fix

       <Tooltip
         content={
           <div className="flex max-w-xs items-start gap-1.5 p-3">
             <BadgeCheck2Fill className="mt-0.5 size-5 shrink-0 text-blue-500" />
             <div className="flex flex-col gap-1">
               <span className="text-sm font-semibold text-neutral-900">
                 Approved Partner
               </span>
               <span className="text-sm font-normal text-neutral-600">
                 This partner is approved in the Dub Partner Network.
               </span>
             </div>
           </div>
         }
       >
-        <BadgeCheck2Fill
-          className={cn(
-            "shrink-0 text-blue-500",
-            size === "small" ? "size-3.5" : "size-5",
-          )}
-        />
+        <span className="inline-flex shrink-0">
+          <BadgeCheck2Fill
+            className={cn(
+              "text-blue-500",
+              size === "small" ? "size-3.5" : "size-5",
+            )}
+          />
+        </span>
       </Tooltip>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/ui/partners/partner-network/partner-network-status-badge.tsx` around
lines 19 - 40, The Tooltip is using asChild but its child BadgeCheck2Fill does
not forward refs, breaking positioning/focus; wrap the BadgeCheck2Fill inside a
DOM element that accepts refs (e.g., a <span> or <div>) and pass that wrapper as
the Tooltip child instead of BadgeCheck2Fill directly (keep existing className
and sizing logic on the wrapper or transfer className appropriately) so
Tooltip.asChild can attach refs and event handlers correctly; update the
partner-network-status-badge component to use Tooltip -> wrapper ->
BadgeCheck2Fill.