vendor: Update vendored sources to duckdb/duckdb@89bcc3e

[Dev] Fix wrong result reported by Roaring Compression `FinalAnalyze` (duckdb/duckdb#15677)

Author: krlmlr

src/duckdb/src/function/table/version/pragma_version.cpp

@@ -1,5 +1,5 @@
 #ifndef DUCKDB_PATCH_VERSION
-#define DUCKDB_PATCH_VERSION "4-dev4489"
+#define DUCKDB_PATCH_VERSION "4-dev4492"
 #endif
 #ifndef DUCKDB_MINOR_VERSION
 #define DUCKDB_MINOR_VERSION 1
@@ -8,10 +8,10 @@
 #define DUCKDB_MAJOR_VERSION 1
 #endif
 #ifndef DUCKDB_VERSION
-#define DUCKDB_VERSION "v1.1.4-dev4489"
+#define DUCKDB_VERSION "v1.1.4-dev4492"
 #endif
 #ifndef DUCKDB_SOURCE_ID
-#define DUCKDB_SOURCE_ID "31cb6c5582"
+#define DUCKDB_SOURCE_ID "89bcc3e2ce"
 #endif
 #include "duckdb/function/table/system_functions.hpp"
 #include "duckdb/main/database.hpp"

src/duckdb/src/include/duckdb/storage/compression/roaring/roaring.hpp

@@ -244,7 +244,9 @@ struct RoaringAnalyzeState : public AnalyzeState {
 	//! Flushed analyze data
 
 	//! The space used by the current segment
-	idx_t space_used = 0;
+	idx_t data_size = 0;
+	idx_t metadata_size = 0;
+
 	//! The total amount of segments to write
 	idx_t segment_count = 0;
 	//! The amount of values in the current segment;

src/duckdb/src/storage/compression/roaring/analyze.cpp

@@ -108,6 +108,7 @@ void RoaringAnalyzeState::Flush(RoaringAnalyzeState &state) {
 }
 
 bool RoaringAnalyzeState::HasEnoughSpaceInSegment(idx_t required_space) {
+	auto space_used = data_size + metadata_size;
 	D_ASSERT(space_used <= info.GetBlockSize());
 	idx_t remaining_space = info.GetBlockSize() - space_used;
 	if (required_space > remaining_space) {
@@ -117,13 +118,15 @@ bool RoaringAnalyzeState::HasEnoughSpaceInSegment(idx_t required_space) {
 }
 
 void RoaringAnalyzeState::FlushSegment() {
+	auto space_used = data_size + metadata_size;
 	if (!current_count) {
 		D_ASSERT(!space_used);
 		return;
 	}
 	metadata_collection.FlushSegment();
 	total_size += space_used;
-	space_used = 0;
+	data_size = 0;
+	metadata_size = 0;
 	current_count = 0;
 	segment_count++;
 }
@@ -146,15 +149,14 @@ void RoaringAnalyzeState::FlushContainer() {
 		arrays_count++;
 	}
 
-	idx_t required_space = metadata_collection.GetMetadataSize(runs_count + arrays_count, runs_count, arrays_count);
+	metadata_size = metadata_collection.GetMetadataSize(runs_count + arrays_count, runs_count, arrays_count);
 
-	required_space += metadata.GetDataSizeInBytes(count);
-	if (!HasEnoughSpaceInSegment(required_space)) {
+	data_size += metadata.GetDataSizeInBytes(count);
+	if (!HasEnoughSpaceInSegment(metadata_size + data_size)) {
 		FlushSegment();
 	}
 	container_metadata.push_back(metadata);
 	metadata_collection.AddMetadata(metadata);
-	space_used += required_space;
 	current_count += count;
 
 	// Reset the container analyze state

src/duckdb/src/storage/table/column_data_checkpointer.cpp

@@ -5,6 +5,7 @@
 #include "duckdb/storage/data_table.hpp"
 #include "duckdb/parser/column_definition.hpp"
 #include "duckdb/storage/table/scan_state.hpp"
+#include "duckdb/main/database.hpp"
 
 namespace duckdb {
 
@@ -240,14 +241,19 @@ vector<CheckpointAnalyzeResult> ColumnDataCheckpointer::DetectBestCompressionMet
 			}
 		}
 
+		auto &checkpoint_state = checkpoint_states[i];
+		auto &col_data = checkpoint_state.get().column_data;
 		if (!chosen_state) {
-			auto &checkpoint_state = checkpoint_states[i];
-			auto &col_data = checkpoint_state.get().column_data;
 			throw FatalException("No suitable compression/storage method found to store column of type %s",
 			                     col_data.type.ToString());
 		}
 		D_ASSERT(compression_idx != DConstants::INVALID_INDEX);
-		result[i] = CheckpointAnalyzeResult(std::move(chosen_state), *functions[compression_idx]);
+
+		auto &best_function = *functions[compression_idx];
+		Logger::Info(db, "FinalAnalyze(%s) result for %s.%s.%d(%s): %d", EnumUtil::ToString(best_function.type),
+		             col_data.info.GetSchemaName(), col_data.info.GetTableName(), col_data.column_index,
+		             col_data.type.ToString(), best_score);
+		result[i] = CheckpointAnalyzeResult(std::move(chosen_state), best_function);
 	}
 	return result;
 }