Skip to content

Commit 2f5270c

Browse files
committed
Swap duckpgq out for prql in the tests
1 parent d52fa8f commit 2f5270c

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

docs/extensions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ UPDATE duckdb.extensions SET enabled = (false|true) WHERE name = 'iceberg';
3636
-- remove an extension
3737
DELETE FROM duckdb.extensions WHERE name = 'iceberg';
3838
-- You can also install community extensions
39-
SELECT duckdb.install_extension('duckpgq', 'community');
39+
SELECT duckdb.install_extension('prql', 'community');
4040
```
4141

4242
There is currently no practical difference between a disabled and uninstalled extension.

test/pycheck/non_superuser_test.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import psycopg.sql
66

77

8-
@pytest.mark.skip(reason="duckpgq not available in duckdb 1.3.0")
98
def test_community_extensions(pg: Postgres):
109
pg.create_user("user1", psycopg.sql.SQL("IN ROLE duckdb_group"))
1110
# Raw extension installation should not be possible non-superusers, because
@@ -19,26 +18,26 @@ def test_community_extensions(pg: Postgres):
1918
match="Permission Error: File system LocalFileSystem has been disabled by configuration",
2019
):
2120
cur.sql(
22-
"SELECT * FROM duckdb.raw_query($$ INSTALL duckpgq FROM community; $$)"
21+
"SELECT * FROM duckdb.raw_query($$ INSTALL prql FROM community; $$)"
2322
)
2423

2524
# Even if such community extensions somehow get installed, it's not possible
2625
# to load them without changing allow_community_extensions. Not even for a
2726
# superuser.
2827
with pg.cur() as cur:
2928
cur.sql("SET duckdb.force_execution = false")
30-
cur.sql("SELECT * FROM duckdb.raw_query($$ INSTALL duckpgq FROM community; $$)")
29+
cur.sql("SELECT * FROM duckdb.raw_query($$ INSTALL prql FROM community; $$)")
3130
with pytest.raises(
3231
Exception,
3332
match="IO Error: Extension .* could not be loaded because its signature is either missing or invalid and unsigned extensions are disabled by configuration",
3433
):
35-
cur.sql("SELECT * FROM duckdb.raw_query($$ LOAD duckpgq; $$)")
34+
cur.sql("SELECT * FROM duckdb.raw_query($$ LOAD prql; $$)")
3635

3736
# But it should be possible to load them after changing that setting.
3837
with pg.cur() as cur:
3938
cur.sql("SET duckdb.allow_community_extensions = true")
4039
cur.sql("SET duckdb.force_execution = false")
41-
cur.sql("SELECT * FROM duckdb.raw_query($$ LOAD duckpgq; $$)")
40+
cur.sql("SELECT * FROM duckdb.raw_query($$ LOAD prql; $$)")
4241

4342
# And that setting is only changeable by superusers
4443
with pg.cur() as cur:

test/regression/expected/extensions.out

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,16 @@ SELECT * FROM duckdb.query($$ SELECT extension_name, loaded, installed, installe
114114
pgduckdb | t | f |
115115
(7 rows)
116116

117-
SELECT duckdb.install_extension('duckpgq', 'community');
118-
ERROR: (PGDuckDB/install_extension_cpp) HTTP Error: Failed to download extension "duckpgq" at URL "http://community-extensions.duckdb.org/v1.3.0/linux_amd64/duckpgq.duckdb_extension.gz" (HTTP 403)
117+
SELECT duckdb.install_extension('prql', 'community');
118+
install_extension
119+
-------------------
120+
121+
(1 row)
119122

120-
Candidate extensions: "autocomplete", "ui", "md", "iceberg", "encodings"
121-
For more info, visit https://duckdb.org/docs/stable/extensions/troubleshooting/?version=v1.3.0&platform=linux_amd64&extension=duckpgq
122123
SELECT last_value FROM duckdb.extensions_table_seq;
123124
last_value
124125
------------
125-
8
126+
10
126127
(1 row)
127128

128129
SELECT * FROM duckdb.query($$ SELECT extension_name, loaded, installed, installed_from FROM duckdb_extensions() WHERE loaded and extension_name != 'jemalloc' $$);
@@ -135,7 +136,8 @@ SELECT * FROM duckdb.query($$ SELECT extension_name, loaded, installed, installe
135136
json | t | t |
136137
parquet | t | t |
137138
pgduckdb | t | f |
138-
(7 rows)
139+
prql | t | t | community
140+
(8 rows)
139141

140142
-- cleanup
141143
TRUNCATE duckdb.extensions;

test/regression/sql/extensions.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ SELECT last_value FROM duckdb.extensions_table_seq;
4040

4141
SELECT * FROM duckdb.query($$ SELECT extension_name, loaded, installed, installed_from FROM duckdb_extensions() WHERE loaded and extension_name != 'jemalloc' $$);
4242

43-
SELECT duckdb.install_extension('duckpgq', 'community');
43+
SELECT duckdb.install_extension('prql', 'community');
4444

4545
SELECT last_value FROM duckdb.extensions_table_seq;
4646

0 commit comments

Comments
 (0)