Skip to content

Commit 49cd676

Browse files
authored
Hopefully fix static build issue in CI (#810)
In CI we sometimes get this error: ``` /usr/bin/ld: cannot find third_party/duckdb/build/release/libduckdb_bundle.a: No such file or directory ``` The intent of this change is to avoid that by adding a correct dependency on the `.a` file in case of a static build.
1 parent fc78e6d commit 49cd676

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ PG_DUCKDB_LINK_FLAGS = -Wl,-rpath,$(PG_LIB)/ -Lthird_party/duckdb/build/$(DUCKDB
4242
DUCKDB_BUILD_DIR = third_party/duckdb/build/$(DUCKDB_BUILD_TYPE)
4343

4444
ifeq ($(DUCKDB_BUILD), ReleaseStatic)
45-
PG_DUCKDB_LINK_FLAGS += third_party/duckdb/build/release/libduckdb_bundle.a
46-
FULL_DUCKDB_LIB = $(DUCKDB_BUILD_DIR)/$(DUCKDB_LIB)
45+
FULL_DUCKDB_LIB = $(DUCKDB_BUILD_DIR)/libduckdb_bundle.a
46+
PG_DUCKDB_LINK_FLAGS += $(FULL_DUCKDB_LIB)
4747
else
48+
FULL_DUCKDB_LIB = $(DUCKDB_BUILD_DIR)/src/libduckdb$(DLSUFFIX)
4849
PG_DUCKDB_LINK_FLAGS += -lduckdb
49-
FULL_DUCKDB_LIB = $(DUCKDB_BUILD_DIR)/src/$(DUCKDB_LIB)/libduckdb$(DLSUFFIX)
5050
endif
5151

5252
ERROR_ON_WARNING ?=

0 commit comments

Comments
 (0)