could not find ExecCheckRTEPerms() under PG 15.13?

[japinli]

What happens?

Hi,

When I try to build pg_duckdb master branch on PG 15.12, I encountered the following error:

src/pgduckdb_planner.cpp: In function ‘void check_view_perms_recursive(Query*)’:
src/pgduckdb_planner.cpp:157:39: error: ‘ExecCheckRTEPerms’ was not declared in this scope; did you mean ‘ExecCheckRTPerms’?
  157 |                         bool result = ExecCheckRTEPerms(rte);
      |                                       ^~~~~~~~~~~~~~~~~
      |                                       ExecCheckRTPerms

It seems that the ExecCheckRTEPerms() is exported by commit 415badc13. Before this commit, it was unusable.

Should we fix this, or just document it?

To Reproduce

git clone --branch REL_15_STABLE https://git.postgresql.org/git/postgresql.git
cd postgresql
git checkout -b 15.12 REL_15_12
mkdir build
cd build
../configure \
        --prefix=/tmp/pg15.12 \
        --enable-tap-tests \
        --enable-debug \
        --enable-cassert \
        --enable-depend \
        --enable-dtrace \
        --with-icu \
        --with-libxml \
        --with-libxslt \
        --with-lz4 \
        --with-openssl \
        --with-pam \
        --with-python \
        CFLAGS='-Wall -Wmissing-prototypes'
make -j $(nproc) -s install
make -j $(nproc) -s -C contrib install
export PATH=/tmp/pg15.12/bin:$PATH
git clone https://github.com/duckdb/pg_duckdb.git
cd pg_duckdb
make

OS:

Ubuntu 24.04, x86_64

pg_duckdb Version (if built from source use commit hash):

6c43a1a

Postgres Version (if built from source use commit hash):

15.12 (50d3d22baba63613d1f1406b2ed460dc9b03c3fc)

Hardware:

No response

Full Name:

Japin Li

Affiliation:

WwIT

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have tested with a source build

Did you include all relevant data sets for reproducing the issue?

No - Other reason (please specify in the issue body)

Did you include all code required to reproduce the issue?

• Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Linux distribution) to reproduce the issue?

• Yes, I have