Merge branch 'release/5.245.0'

Author: github-actions[bot]

.github/workflows/e2e-nightly-autofill.yml

@@ -60,13 +60,26 @@ jobs:
         with:
           api-key: ${{ secrets.ROBIN_API_KEY }}
           project-id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
-          name: autofill_${{ github.sha }}
+          name: autofill_critical_path_${{ github.sha }}
           timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
           app-file: apk/release.apk
           android-api-level: 30
           workspace: .maestro
           include-tags: autofillNoAuthTests
 
+      - name: Autofill web flows
+        uses: mobile-dev-inc/[email protected]
+        timeout-minutes: 120
+        with:
+          api-key: ${{ secrets.ROBIN_API_KEY }}
+          project-id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
+          name: autofill_secondary_functionality_${{ github.sha }}
+          timeout: ${{ vars.ROBIN_TIMEOUT_MINUTES }}
+          app-file: apk/release.apk
+          android-api-level: 30
+          workspace: .maestro
+          include-tags: autofillBackfillingUsername,autofillPasswordGeneration
+
       - name: Create Asana task when workflow failed
         if: ${{ failure() }}
         id: create-failure-task
@@ -75,6 +88,6 @@ jobs:
           asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
           asana-project: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
           asana-section: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
-          asana-task-name: GH Workflow Failure - Autofill Critical Path E2E Flows (Robin)
-          asana-task-description: Autofill critical path tests have failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
+          asana-task-name: GH Workflow Failure - Autofill E2E Flows (Robin)
+          asana-task-description: Autofill tests have failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
           action: 'create-asana-task'

.github/workflows/release_nightly.yml

@@ -97,20 +97,20 @@ jobs:
       - name: Clean project
         if: steps.check_for_changes.outputs.has_changes == 'true'
         run: |
-          gradle clean          
+          ./gradlew clean          
 
       - name: Assemble the bundle
         env:
           NETP_DEBUG_SERVER_TOKEN: ${{ secrets.NETP_DEBUG_SERVER_TOKEN }}
           MALICIOUS_SITE_PROTECTION_AUTH_TOKEN: ${{ secrets.MALICIOUS_SITE_PROTECTION_AUTH_TOKEN }}
         if: steps.check_for_changes.outputs.has_changes == 'true'
-        run: gradle bundleInternalRelease -PversionNameSuffix=-nightly -PuseUploadSigning -PlatestTag=${{ steps.get_latest_tag.outputs.latest_tag }} -Pbuild-date-time
+        run: ./gradlew bundleInternalRelease -PversionNameSuffix=-nightly -PuseUploadSigning -PlatestTag=${{ steps.get_latest_tag.outputs.latest_tag }} -Pbuild-date-time
 
       - name: Generate nightly version name
         if: steps.check_for_changes.outputs.has_changes == 'true'
         id: generate_version_name
         run: |
-          output=$(gradle getBuildVersionName -PversionNameSuffix=-nightly -PlatestTag=${{ steps.get_latest_tag.outputs.latest_tag }} --quiet | tail -n 1)
+          output=$(./gradlew getBuildVersionName -PversionNameSuffix=-nightly -PlatestTag=${{ steps.get_latest_tag.outputs.latest_tag }} --quiet | tail -n 1)
           echo "version=$output" >> $GITHUB_OUTPUT
 
       - name: Capture App Bundle Path

.maestro/autofill/3_autofill_prompted_to_save_creds_on_form.yaml

@@ -23,6 +23,12 @@ tags:
 
         - tapOn:
             id: "username"
+
+        - runFlow: steps/decline_in_browser_password_import.promo.yaml
+
+        - tapOn:
+            id: "username"
+
         - inputText: "user"
         - tapOn:
             id: "password"

.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml

@@ -22,6 +22,9 @@ tags:
 
       # simulate a partial login form by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
+
       - inputText: "usernameFromBackfill"
       - pressKey: Back
 

.maestro/autofill/backfillingUsername/multi_step_login_username_not_backfilled_if_provided_explicitly.yaml

@@ -22,6 +22,9 @@ tags:
 
       # simulate a partial login form by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
+
       - inputText: "usernameFromBackfill"
       - pressKey: Back
 

.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_autogenerated.yaml

@@ -22,6 +22,9 @@ tags:
 
       # simulate a partial form submission by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
+
       - inputText: "usernameFromBackfill"
       - pressKey: Back
 

.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_manually_entered.yaml

@@ -22,7 +22,11 @@ tags:
 
       # simulate a partial form submission by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
       - inputText: "usernameFromBackfill"
+      - tapOn: "Username"
+
       - pressKey: Back
 
       - tapOn:

.maestro/autofill/backfillingUsername/password_reset_flow_autogenerated_password.yaml

@@ -22,6 +22,9 @@ tags:
 
       # simulate a partial login form by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
+
       - inputText: "usernameFromBackfill"
       - pressKey: Back
 

.maestro/autofill/backfillingUsername/password_reset_flow_for_existing_credential_generated_password.yaml

@@ -22,6 +22,9 @@ tags:
 
       # simulate a partial login form by first submitting just the username
       - tapOn: "Username"
+      - runFlow: ../steps/decline_in_browser_password_import.promo.yaml
+      - tapOn: "Username"
+
       - inputText: "existingUser"
       - pressKey: Back
 

.maestro/autofill/steps/decline_in_browser_password_import.promo.yaml

@@ -0,0 +1,9 @@
+appId: com.duckduckgo.mobile.android
+---
+
+# dismiss any offers to autofill from existing credentials
+- runFlow:
+    when:
+      visible: "Bring your passwords from Google to DuckDuckGo"
+    commands:
+      - tapOn: "Don't Ask Again"