Merge branch 'hotfix/5.243.1'

Author: anikiki

app/version/version.properties

@@ -1 +1 @@
-VERSION=5.243.0
+VERSION=5.243.1

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/RealDuckChat.kt

@@ -320,11 +320,12 @@ class RealDuckChat @Inject constructor(
     }
 
     override fun openDuckChatSettings() {
-        // todo what happens with this interaction? closeDuckChat() would go back to browser activity
         val intent = globalActivityStarter.startIntent(context, DuckChatSettingsNoParams)
         intent?.flags = Intent.FLAG_ACTIVITY_NEW_TASK
         context.startActivity(intent)
-        closeDuckChat()
+        appCoroutineScope.launch {
+            closeChatFlow.emit(Unit)
+        }
     }
 
     override fun closeDuckChat() {

duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/RealDuckChatTest.kt

@@ -414,6 +414,15 @@ class RealDuckChatTest {
     fun whenOpenDuckChatSettingsCalledThenGlobalActivityStarterCalledWithDuckChatSettings() = runTest {
         whenever(mockGlobalActivityStarter.startIntent(any(), any<ActivityParams>())).thenReturn(Intent())
 
+        val testLifecycleOwner = TestLifecycleOwner(initialState = CREATED)
+
+        var onCloseCalled = false
+        testee.observeCloseEvent(testLifecycleOwner) {
+            onCloseCalled = true
+        }
+
+        testLifecycleOwner.currentState = Lifecycle.State.STARTED
+
         testee.openDuckChatSettings()
 
         verify(mockGlobalActivityStarter).startIntent(mockContext, DuckChatSettingsNoParams)
@@ -424,7 +433,9 @@ class RealDuckChatTest {
 
         assertEquals(Intent.FLAG_ACTIVITY_NEW_TASK, capturedIntent.flags)
 
-        verify(testee).closeDuckChat()
+        advanceUntilIdle()
+
+        assertTrue(onCloseCalled)
     }
 
     @Test