Replace the app label with a horizontal divider

Author: 0nko

app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchActivity.kt

@@ -146,7 +146,9 @@ class SystemSearchActivity : DuckDuckGoActivity() {
     private var nestedScrollViewPosition: Int = 0
     private var nestedScrollViewRestorePosition: Int = 0
 
-    private val isOmnibarAtTop = settingsDataStore.omnibarPosition == OmnibarPosition.TOP
+    private val isOmnibarAtTop by lazy {
+        settingsDataStore.omnibarPosition == OmnibarPosition.TOP
+    }
 
     private val systemSearchOnboarding
         get() = binding.includeSystemSearchOnboarding
@@ -473,7 +475,7 @@ class SystemSearchActivity : DuckDuckGoActivity() {
         deviceAppSuggestionsAdapter.updateData(viewState.appResults)
 
         binding.autocompleteSuggestions.isVisible = !viewState.autocompleteResults.suggestions.isEmpty()
-        binding.deviceLabel.isVisible = viewState.appResults.isNotEmpty()
+        binding.listDivider.isVisible = viewState.appResults.isNotEmpty()
         binding.deviceAppSuggestions.isVisible = !viewState.appResults.isEmpty()
     }
 

app/src/main/res/layout/activity_system_search.xml

@@ -222,30 +222,31 @@
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
                 app:layout_constraintEnd_toEndOf="parent"
+                app:layout_constraintHorizontal_bias="1.0"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="parent"
                 tools:itemCount="4"
                 tools:listitem="@layout/item_autocomplete_search_suggestion" />
 
-            <com.duckduckgo.common.ui.view.text.DaxTextView
-                android:id="@+id/deviceLabel"
-                android:layout_width="0dp"
-                android:layout_height="wrap_content"
-                android:paddingHorizontal="?attr/autocompleteListItemHorizontalPadding"
-                android:paddingVertical="@dimen/keyline_2"
-                android:text="@string/systemSearchDeviceAppLabel"
-                android:visibility="gone"
+            <View
+                android:id="@+id/listDivider"
+                android:layout_width="match_parent"
+                android:layout_height="0.5dp"
+                android:background="?attr/daxColorShade"
+                android:layout_marginVertical="@dimen/keyline_2"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toBottomOf="@id/autocompleteSuggestions"/>
+                app:layout_constraintTop_toBottomOf="@id/autocompleteSuggestions"
+                app:layout_constraintBottom_toTopOf="@id/deviceAppSuggestions"/>
 
             <androidx.recyclerview.widget.RecyclerView
                 android:id="@+id/deviceAppSuggestions"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
+                android:layout_marginTop="@dimen/keyline_2"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toBottomOf="@id/deviceLabel"
+                app:layout_constraintTop_toBottomOf="@id/listDivider"
                 tools:itemCount="4"
                 tools:listitem="@layout/item_device_app_suggestion" />
 

app/src/main/res/values/strings.xml

@@ -426,7 +426,6 @@
     <string name="crashedWebViewErrorAction">"Reload"</string>
 
     <!-- System Search-->
-    <string name="systemSearchDeviceAppLabel">From This Device</string>
     <string name="systemSearchAppNotFound">Application could not be found</string>
     <string name="systemSearchOnboardingThanks">Thanks for choosing DuckDuckGo!\nUsing our browser helps keep you protected from hackers, scammers, and data-hungry companies.</string>
     <string name="systemSearchOnboardingFeaturesIntroText">The DuckDuckGo app also:</string>