Skip to content

Commit e547474

Browse files
CDRussellkarlenDimla
authored andcommitted
Revert "Allow scrolling all of the password management list mode screen" (#5445)
Task/Issue URL: https://app.asana.com/0/608920331025315/1209106756565265/f ### Description Reverts changes made in #5377 as it introduces performance issues on the password management screen with larger password list sizes. Depending on the device / list size, it can be crippling performance. ### Steps to test this PR - [x] install `internal` variant to make the next step easier - [x] Add 500+ passwords (can be done in `Autofill Dev Settings` screen, using the **Add a lot of sample logins** button) - [x] Visit password management screen and verify there isn’t a huge delay in rendering the password list For contrast, if you try this on `develop` you will notice a large perf issue. Co-authored-by: Craig Russell <[email protected]>
1 parent dd2ce2e commit e547474

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

autofill/autofill-impl/src/main/res/layout/fragment_autofill_management_list_mode.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@
7878
<androidx.recyclerview.widget.RecyclerView
7979
android:id="@+id/logins"
8080
android:layout_width="0dp"
81-
android:layout_height="wrap_content"
81+
android:layout_height="0dp"
8282
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
83+
app:layout_constraintBottom_toBottomOf="parent"
8384
app:layout_constraintEnd_toEndOf="parent"
8485
app:layout_constraintStart_toStartOf="parent"
8586
app:layout_constraintTop_toBottomOf="@id/topDivider" />

0 commit comments

Comments
 (0)