Release build 8.19.0 [ci release]

mgurgel · github-actions[bot] · commit 1d5f27d5167e · 2025-05-02T10:33:41.000Z
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -1,3 +1 @@
-- onboarding: refresh assets (#1659)
-- Onboarding: Fix welcome message appearing off screen (#1650)
-- ntp: remove legacy menu (#1638)
+- Add query param color=white to  (#1662)
diff --git a/Sources/ContentScopeScripts/dist/pages/duckplayer/dist/index.js b/Sources/ContentScopeScripts/dist/pages/duckplayer/dist/index.js
@@ -1820,6 +1820,7 @@
       }
       url.searchParams.set("rel", "0");
       url.searchParams.set("modestbranding", "1");
+      url.searchParams.set("color", "white");
       if (this.timestamp && this.timestamp.seconds > 0) {
         url.searchParams.set("start", String(this.timestamp.seconds));
       }
diff --git a/Sources/ContentScopeScripts/dist/pages/duckplayer/index.html b/Sources/ContentScopeScripts/dist/pages/duckplayer/index.html
@@ -2955,6 +2955,7 @@
       }
       url.searchParams.set("rel", "0");
       url.searchParams.set("modestbranding", "1");
+      url.searchParams.set("color", "white");
       if (this.timestamp && this.timestamp.seconds > 0) {
         url.searchParams.set("start", String(this.timestamp.seconds));
       }
diff --git a/build/android/pages/duckplayer/dist/index.js b/build/android/pages/duckplayer/dist/index.js
@@ -1820,6 +1820,7 @@
       }
       url.searchParams.set("rel", "0");
       url.searchParams.set("modestbranding", "1");
+      url.searchParams.set("color", "white");
       if (this.timestamp && this.timestamp.seconds > 0) {
         url.searchParams.set("start", String(this.timestamp.seconds));
       }
diff --git a/build/integration/pages/duckplayer/dist/index.js b/build/integration/pages/duckplayer/dist/index.js
@@ -1820,6 +1820,7 @@
       }
       url.searchParams.set("rel", "0");
       url.searchParams.set("modestbranding", "1");
+      url.searchParams.set("color", "white");
       if (this.timestamp && this.timestamp.seconds > 0) {
         url.searchParams.set("start", String(this.timestamp.seconds));
       }
diff --git a/build/windows/pages/duckplayer/dist/index.js b/build/windows/pages/duckplayer/dist/index.js
@@ -1820,6 +1820,7 @@
       }
       url.searchParams.set("rel", "0");
       url.searchParams.set("modestbranding", "1");
+      url.searchParams.set("color", "white");
       if (this.timestamp && this.timestamp.seconds > 0) {
         url.searchParams.set("start", String(this.timestamp.seconds));
       }
diff --git a/special-pages/pages/duckplayer/app/embed-settings.js b/special-pages/pages/duckplayer/app/embed-settings.js
@@ -71,6 +71,7 @@ export class EmbedSettings {
 
         url.searchParams.set('rel', '0'); // shows related videos from the same channel as the video
         url.searchParams.set('modestbranding', '1'); // disables showing the YouTube logo in the video control bar
+        url.searchParams.set('color', 'white'); // Forces legacy YouTube player UI
 
         if (this.timestamp && this.timestamp.seconds > 0) {
             url.searchParams.set('start', String(this.timestamp.seconds)); // if timestamp supplied, start video at specific point
diff --git a/special-pages/pages/duckplayer/integration-tests/duck-player.js b/special-pages/pages/duckplayer/integration-tests/duck-player.js
@@ -5,9 +5,10 @@ import { perPlatform } from 'injected/integration-test/type-helpers.mjs';
 
 const MOCK_VIDEO_ID = 'VIDEO_ID';
 const MOCK_VIDEO_TITLE = 'Embedded Video - YouTube';
-const youtubeEmbed = (id) => 'https://www.youtube-nocookie.com/embed/' + id + '?iv_load_policy=1&autoplay=1&rel=0&modestbranding=1';
+const youtubeEmbed = (id) =>
+    'https://www.youtube-nocookie.com/embed/' + id + '?iv_load_policy=1&autoplay=1&rel=0&modestbranding=1&color=white';
 const youtubeEmbedIOS = (id) =>
-    'https://www.youtube-nocookie.com/embed/' + id + '?iv_load_policy=1&autoplay=1&muted=1&rel=0&modestbranding=1';
+    'https://www.youtube-nocookie.com/embed/' + id + '?iv_load_policy=1&autoplay=1&muted=1&rel=0&modestbranding=1&color=white';
 const html = {
     unsupported: `<html><head><title>${MOCK_VIDEO_TITLE}</title></head>
 <body>
diff --git a/special-pages/pages/duckplayer/unit-tests/embed-settings.mjs b/special-pages/pages/duckplayer/unit-tests/embed-settings.mjs
@@ -5,7 +5,7 @@ import { EmbedSettings } from '../app/embed-settings.js';
 describe('creates embed url', () => {
     it('handles duck scheme', () => {
         const actual = EmbedSettings.fromHref('duck://player/123')?.toEmbedUrl();
-        const expected = 'https://www.youtube-nocookie.com/embed/123?iv_load_policy=1&autoplay=1&rel=0&modestbranding=1';
+        const expected = 'https://www.youtube-nocookie.com/embed/123?iv_load_policy=1&autoplay=1&rel=0&modestbranding=1&color=white';
         deepEqual(actual, expected);
     });
     it('handles duck scheme with timestamp', () => {
@@ -15,6 +15,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
             start: '3723',
         };
         if (!actual) throw new Error('unreachable');
@@ -28,6 +29,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
             start: '3723',
         };
         if (!actual) throw new Error('unreachable');
@@ -41,6 +43,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
             start: '3723',
         };
         if (!actual) throw new Error('unreachable');
@@ -54,6 +57,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
         };
         if (!actual) throw new Error('unreachable');
         const asParams = Object.fromEntries(new URL(actual).searchParams);
@@ -67,6 +71,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
             muted: '1',
         };
         if (!actual) throw new Error('unreachable');
@@ -80,6 +85,7 @@ describe('creates embed url', () => {
             iv_load_policy: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
         };
         if (!actual) throw new Error('unreachable');
         const asParams = Object.fromEntries(new URL(actual).searchParams);
@@ -93,6 +99,7 @@ describe('creates embed url', () => {
             autoplay: '1',
             rel: '0',
             modestbranding: '1',
+            color: 'white',
         };
         if (!actual) throw new Error('unreachable');
         const asParams = Object.fromEntries(new URL(actual).searchParams);

Original file line number	Diff line number	Diff line change
`@@ -1820,6 +1820,7 @@`
`1820`	`1820`	`}`
`1821`	`1821`	`url.searchParams.set("rel", "0");`
`1822`	`1822`	`url.searchParams.set("modestbranding", "1");`
	`1823`	`+ url.searchParams.set("color", "white");`
`1823`	`1824`	`if (this.timestamp && this.timestamp.seconds > 0) {`
`1824`	`1825`	`url.searchParams.set("start", String(this.timestamp.seconds));`
`1825`	`1826`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2955,6 +2955,7 @@`
`2955`	`2955`	`}`
`2956`	`2956`	`url.searchParams.set("rel", "0");`
`2957`	`2957`	`url.searchParams.set("modestbranding", "1");`
	`2958`	`+ url.searchParams.set("color", "white");`
`2958`	`2959`	`if (this.timestamp && this.timestamp.seconds > 0) {`
`2959`	`2960`	`url.searchParams.set("start", String(this.timestamp.seconds));`
`2960`	`2961`	`}`