Skip to content

Commit c130623

Browse files
noisysocksmgurgel
andauthored
Onboarding: Fix welcome message appearing off screen (#1650)
* Onboarding: Prevent welcome message having a negative translateY value * Ignore stylelint error * Position: fixed --------- Co-authored-by: Marcos Gurgel <[email protected]>
1 parent 6f4e461 commit c130623

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

special-pages/pages/onboarding/app/components/App2.module.css

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
transition: transform 0.3s ease-in-out;
2424
transform: translateY(0);
2525

26-
&[data-current="welcome"] {
27-
transform: translateY(calc(50vh - 288px));
28-
}
26+
&[data-current="welcome"],
2927
&[data-current="getStarted"] {
30-
transform: translateY(calc(50vh - 288px));
28+
/* max() is not supported by stylelint's CSS parser: https://github.com/csstree/csstree/issues/164 */
29+
/* stylelint-disable-next-line csstree/validator */
30+
transform: translateY(max(50vh - 288px, 0px));
3131
}
3232
}
3333

special-pages/pages/onboarding/app/components/v3/Hiker.module.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.hiker {
22
bottom: 0;
3-
position: absolute;
3+
position: fixed;
44
right: var(--sp-35);
55

66
animation-name: hiker-appear;

0 commit comments

Comments
 (0)