Update Danger to support monorepo changes (#14)

Task: https://app.asana.com/0/1199333091098016/1209477587643660

This PR updates Danger to support the monorepo changes. It also fixes an issue where the macOS embedded file check was no longer working, as the format of that URL had changed.

Author: samsymons

org/allPRs.ts

@@ -57,9 +57,9 @@ export const internalLink = async () => {
     }
 }
 
-export const xcodeprojConfiguration = async () => {
-    if (danger.github.thisPR.repo == "macos-browser") {
-        const projectFile = "DuckDuckGo.xcodeproj/project.pbxproj";
+export const xcodeprojConfiguration_macOS = async () => {
+    if (danger.github.thisPR.repo == "apple-browsers") {
+        const projectFile = "macOS/DuckDuckGo-macOS.xcodeproj/project.pbxproj";
         if (danger.git.modified_files.includes(projectFile)) {
             let diff = await danger.git.diffForFile(projectFile);
             let addedLines = diff?.added.split(/\n/);
@@ -71,7 +71,7 @@ export const xcodeprojConfiguration = async () => {
             // * arbitrary number of any characters (the value can be empty)
             // * a semicolon
             if (addedLines?.find(value => /^\+\t+[A-Z_0-9]* =.*;$/.test(value))) {
-                fail("No configuration is allowed inside Xcode project file - use xcconfig files instead.");
+                fail("No configuration is allowed inside macOS Xcode project file - use xcconfig files instead.");
             }
         }
     }
@@ -141,78 +141,57 @@ async function checkForMismatch(modifiedFiles: any, sourceCodeUrlFilePath: strin
     return false;
 }
 
-async function trackerBlockingMismatch(repository: string, modifiedFiles: any) {
+async function trackerBlockingMismatch(modifiedFiles: any) {
     // Fail if Tracker Blocking config URL is different between code and script
-    var tdsUrlProviderFilePath = ''; 
-    var updateEmbeddedFilePath = ''; 
-    var tdsUrlProviderRegex = '';
-    var updateEmbeddedRegex = '';
-
-    // Configure
-    switch (repository) {
-        case "iOS":
-            tdsUrlProviderFilePath = 'Core/AppURLs.swift';
-            updateEmbeddedFilePath = 'scripts/update_embedded.sh';
-
-            tdsUrlProviderRegex = 'static let trackerDataSet = URL.*string:.*staticBase.*trackerblocking\/(.*)\".*';
-            updateEmbeddedRegex = 'performUpdate \'https://staticcdn.duckduckgo.com/trackerblocking/(.*)\' \".*';
-            break;
-        case "macos-browser":
-            tdsUrlProviderFilePath = 'DuckDuckGo/AppDelegate/AppConfigurationURLProvider.swift';
-            updateEmbeddedFilePath = 'scripts/update_embedded.sh';
-
-            tdsUrlProviderRegex = 'case \.trackerDataSet: return URL.string: \"(.*)\".*';
-            updateEmbeddedRegex = 'TDS_URL=\"(.*)\"';
-            break;
-        default:
-            return;
-    } 
+    let tdsUrlProviderFileiOSPath = 'iOS/Core/AppURLs.swift';
+    let updateEmbeddedFileiOSPath = 'iOS/scripts/update_embedded.sh';
+    let tdsUrlProvideriOSRegex = 'static let trackerDataSet = URL.*string:.*staticBase.*trackerblocking\/(.*)\".*';
+    let updateEmbeddediOSRegex = 'performUpdate \'https://staticcdn.duckduckgo.com/trackerblocking/(.*)\' \".*';
+
+    let tdsUrlProviderFilemacOSPath = 'macOS/DuckDuckGo/Application/AppConfigurationURLProvider.swift';
+    let updateEmbeddedFilemacOSPath = 'macOS/scripts/update_embedded.sh';
+    let tdsUrlProvidermacOSRegex = 'public static let defaultTrackerDataURL = URL.string: \"(.*)\".*';
+    let updateEmbeddedmacOSRegex = 'TDS_URL=\"(.*)\"';
+
+    const iosResult = await checkForMismatch(modifiedFiles, tdsUrlProviderFileiOSPath, tdsUrlProvideriOSRegex, updateEmbeddedFileiOSPath, updateEmbeddediOSRegex);
+    if (iosResult) {
+        fail(`iOS Content Tracker URL mismatch. Please check ${tdsUrlProviderFileiOSPath} and ${updateEmbeddedFileiOSPath}`)
+    }
 
-    const res = await checkForMismatch(modifiedFiles, tdsUrlProviderFilePath, tdsUrlProviderRegex, updateEmbeddedFilePath, updateEmbeddedRegex);
-    if (res) {
-        fail(`Content Tracker URL mismatch. Please check ${tdsUrlProviderFilePath} and ${updateEmbeddedFilePath}`)
+    const macosResult = await checkForMismatch(modifiedFiles, tdsUrlProviderFilemacOSPath, tdsUrlProvidermacOSRegex, updateEmbeddedFilemacOSPath, updateEmbeddedmacOSRegex);
+    if (macosResult) {
+        fail(`macOS Content Tracker URL mismatch. Please check ${tdsUrlProviderFilemacOSPath} and ${updateEmbeddedFilemacOSPath}`)
     }
 }
 
-async function privacyConfigMismatch (repository: string, modifiedFiles: any) {
+async function privacyConfigMismatch(modifiedFiles: any) {
     // Fail if Tracker Blocking config URL is different between code and script
-    var appConfigUrlProviderFilePath = ''; 
-    var updateEmbeddedFilePath = ''; 
-    var configUrlProviderRegex = '';
-    var updateEmbeddedRegex = '';
-
-    // Configure
-    switch (repository) {
-        case "iOS":
-            appConfigUrlProviderFilePath = 'Core/AppURLs.swift';
-            updateEmbeddedFilePath = 'scripts/update_embedded.sh';
-
-            configUrlProviderRegex = 'static let privacyConfig = URL.*string:.*staticBase.*trackerblocking\/config\/(.*)\".*';
-            updateEmbeddedRegex = 'performUpdate \'https://staticcdn.duckduckgo.com/trackerblocking/config/(.*)\' \".*';
-            break;
-        case "macos-browser":
-            appConfigUrlProviderFilePath = 'DuckDuckGo/AppDelegate/AppConfigurationURLProvider.swift';
-            updateEmbeddedFilePath = 'scripts/update_embedded.sh';
+    let appConfigUrlProviderFileiOSPath = 'iOS/Core/AppURLs.swift';
+    let updateEmbeddedFileiOSPath = 'iOS/scripts/update_embedded.sh';
+    let configUrlProvideriOSRegex = 'static let privacyConfig = URL.*string:.*staticBase.*trackerblocking\/config\/(.*)\".*';
+    let updateEmbeddediOSRegex = 'performUpdate \'https://staticcdn.duckduckgo.com/trackerblocking/config/(.*)\' \".*';
+
+    let appConfigUrlProviderFilemacOSPath = 'macOS/DuckDuckGo/Application/AppConfigurationURLProvider.swift';
+    let updateEmbeddedFilemacOSPath = 'macOS/scripts/update_embedded.sh';
+    let configUrlProvidermacOSRegex = 'public static let defaultPrivacyConfigurationURL = URL.string: \"(.*)\".*';
+    let updateEmbeddedmacOSRegex = 'CONFIG_URL=\"(.*)\"';
+
+    const iosResult = await checkForMismatch(modifiedFiles, appConfigUrlProviderFileiOSPath, configUrlProvideriOSRegex, updateEmbeddedFileiOSPath, updateEmbeddediOSRegex);
+    if (iosResult) {
+        fail(`iOS Privacy Config URL mismatch. Please check ${appConfigUrlProviderFileiOSPath} and ${updateEmbeddedFileiOSPath}`)
+    }
 
-            configUrlProviderRegex = 'case \.privacyConfiguration: return URL.string: \"(.*)\".*';
-            updateEmbeddedRegex = 'CONFIG_URL=\"(.*)\"';
-            break;
-        default:
-            return;
-    } 
-    
-    const res = await checkForMismatch(modifiedFiles, appConfigUrlProviderFilePath, configUrlProviderRegex, updateEmbeddedFilePath, updateEmbeddedRegex);
-    if (res) {
-        fail(`Privacy Config URL mismatch. Please check ${appConfigUrlProviderFilePath} and ${updateEmbeddedFilePath}`)
+    const macosResult = await checkForMismatch(modifiedFiles, appConfigUrlProviderFilemacOSPath, configUrlProvidermacOSRegex, updateEmbeddedFilemacOSPath, updateEmbeddedmacOSRegex);
+    if (macosResult) {
+        fail(`macOS Privacy Config URL mismatch. Please check ${appConfigUrlProviderFilemacOSPath} and ${updateEmbeddedFilemacOSPath}`)
     }
 }
 
 export const embeddedFilesURLMismatch = async() => {
-    const repo = danger.github.thisPR.repo;
     const modifiedFiles = danger.git.modified_files;
 
-    await trackerBlockingMismatch(repo, modifiedFiles)
-    await privacyConfigMismatch(repo, modifiedFiles)
+    await trackerBlockingMismatch(modifiedFiles)
+    await privacyConfigMismatch(modifiedFiles)
 }
 
 export const releaseAndHotfixBranchBSKChangeWarning = async () => {  
@@ -235,7 +214,7 @@ export const releaseAndHotfixBranchBSKChangeWarning = async () => {
 export default async () => {
     await prSize()
     await internalLink()
-    await xcodeprojConfiguration()
+    await xcodeprojConfiguration_macOS()
     await localizedStrings()
     await licensedFonts()
     await newColors()