Check for added feature flags.

Author: samsymons

org/allPRs.ts

@@ -129,6 +129,26 @@ export const singletons = async () => {
     }
 }
 
+export const remoteReleasableFeatureWarning = async () => {
+    const changedFiles = [
+        ...danger.git.modified_files,
+        ...danger.git.created_files
+    ].filter(file => file.endsWith(".swift"));
+
+    if (changedFiles.length === 0) {
+        return;
+    }
+
+    for (const file of changedFiles) {
+        let diff = await danger.git.diffForFile(file);
+        let addedLines = diff?.added.split(/\n/);
+        if (addedLines?.find(value => value.startsWith("+") && value.includes(".remoteReleasable(.feature"))) {
+            warn("⚠️ Parent feature flags do not support rollouts - if you wish to use a rollout for your feature, please use a subfeature flag.");
+            return;
+        }
+    }
+}
+
 export const localizedStrings = async () => {
     for (let file of danger.git.modified_files) {
         let diff = await danger.git.diffForFile(file);
@@ -264,6 +284,7 @@ export default async () => {
     await xcodeprojConfiguration_macOS()
     await xcodeprojObjectVersion_macOS()
     await singletons()
+    await remoteReleasableFeatureWarning()
     await localizedStrings()
     await licensedFonts()
     await newColors()

tests/remoteReleasableFeatureWarning.allPRs.test.ts

@@ -0,0 +1,59 @@
+jest.mock("danger", () => jest.fn())
+import danger from 'danger'
+const dm = danger as any;
+
+import { remoteReleasableFeatureWarning } from '../org/allPRs'
+
+beforeEach(() => {
+    dm.addedLines = ""
+    dm.warn = jest.fn().mockReturnValue(true);
+
+    dm.danger = {
+        git: {
+            diffForFile: async (_filename) => {
+                return { added: dm.addedLines }
+            },
+            modified_files: [
+                "ModifiedFile.swift"
+            ],
+            created_files: [
+                "CreatedFile.swift"
+            ]
+        }
+    }
+})
+
+describe("remoteReleasable(.feature warning", () => {
+    it("does not warn with no changes to Swift files", async () => {
+        dm.danger.git.modified_files = ["ModifiedFile.m"]
+        dm.danger.git.created_files = []
+
+        await remoteReleasableFeatureWarning()
+        expect(dm.warn).not.toHaveBeenCalled()
+    })
+
+    it("does not warn with no diff in Swift files", async () => {
+        dm.danger.git.diffForFile = async (_filename) => {}
+
+        await remoteReleasableFeatureWarning()
+        expect(dm.warn).not.toHaveBeenCalled()
+    })
+
+    it("does not warn with deletions", async () => {
+        dm.addedLines = `
+-        .remoteReleasable(.feature("example"))
+        `
+
+        await remoteReleasableFeatureWarning()
+        expect(dm.warn).not.toHaveBeenCalled()
+    })
+
+    it("warns with remoteReleasable(.feature additions", async () => {
+        dm.addedLines = `
++        .remoteReleasable(.feature("example"))
+        `
+
+        await remoteReleasableFeatureWarning()
+        expect(dm.warn).toHaveBeenCalledWith("⚠️ Parent feature flags do not support rollouts - if you wish to use a rollout for your feature, please use a subfeature flag.")
+    })
+})