Commit 3d4f3a8
committed
Add missing globals devDependency after eslint 10 bump (PR #3689)
eslint 9.x pulled in globals@14.0.0 transitively via @eslint/eslintrc
(its legacy .eslintrc compatibility shim), which npm hoisted to the
root node_modules/globals. eslint.config.mjs imports 'globals' directly
but never declared it as a dependency, relying on that hoisting.
eslint 10 drops @eslint/eslintrc, so globals is no longer pulled in at
the root (only nested under eslint-plugin-n for its own use), and
`npm run eslint` fails with ERR_MODULE_NOT_FOUND for 'globals'. This
matches the "lint" job failures on PR #3689's dependabot build-group
bump (esbuild 0.28.1->0.28.2, eslint 9.39.4->10.11.0, sass
1.102.0->1.104.1).
Declaring globals explicitly as a devDependency fixes eslint.config.mjs
resolution; verified `npm run lint` (eslint, prettier, tsc,
check-lockfile) and `npm run test.node` pass locally with this change.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019cuRycMWwzr7smwxqgNpM91 parent 6468c3b commit 3d4f3a8
2 files changed
Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
0 commit comments