Add support for Asana V1 URLs

Author: ayoy

lib/fastlane/plugin/ddg_apple_automation/helper/asana_helper.rb

@@ -15,7 +15,12 @@ class AsanaHelper # rubocop:disable Metrics/ClassLength
       ASANA_API_URL = "https://app.asana.com/api/1.0"
       ASANA_TASK_URL_TEMPLATE = "https://app.asana.com/0/0/%s/f"
       ASANA_TAG_URL_TEMPLATE = "https://app.asana.com/0/%s/list"
-      ASANA_TASK_URL_REGEX = %r{https://app.asana.com/[0-9]/[0-9]+/([0-9]+)(:/f)?}
+
+      # https://app.asana.com/0/<project_id>/<task_id>
+      ASANA_V0_TASK_URL_REGEX = %r{https://app.asana.com/0/[0-9]+/([0-9]+)(?:/f)?}
+      # https://app.asana.com/<url_format_version>/<workspace_id>/<object_name>/<object_id>/<subobject_name>/<subobject_id>
+      ASANA_V1_TASK_URL_REGEX = %r{https://app.asana.com/1/[0-9]+(?:/[0-9a-z/]*)?/task/([0-9]+)(:?/[0-9a-z/]*)?(?:\?focus=true)?}
+
       ASANA_WORKSPACE_ID = "137249556945"
 
       IOS_HOTFIX_TASK_TEMPLATE_ID = "1209242676101485"
@@ -53,14 +58,14 @@ def self.asana_tag_url(tag_id)
       end
 
       def self.extract_asana_task_id(task_url, set_gha_output: true)
-        if (match = task_url.match(ASANA_TASK_URL_REGEX))
+        if (match = task_url.match(ASANA_V0_TASK_URL_REGEX)) || (match = task_url.match(ASANA_V1_TASK_URL_REGEX))
           task_id = match[1]
           if set_gha_output
             Helper::GitHubActionsHelper.set_output("asana_task_id", task_id)
           end
           task_id
         else
-          UI.user_error!("URL has incorrect format (attempted to match #{ASANA_TASK_URL_REGEX})")
+          UI.user_error!("URL has incorrect format (attempted to match #{ASANA_V0_TASK_URL_REGEX} or #{ASANA_V1_TASK_URL_REGEX})")
         end
       end
 

spec/asana_helper_spec.rb

@@ -17,24 +17,40 @@ def asana_task_url(task_id)
   end
 
   describe "#extract_asana_task_id" do
-    it "extracts task ID" do
-      expect(extract_asana_task_id("https://app.asana.com/0/0/0")).to eq("0")
-    end
+    context "v0 task URL" do
+      it "extracts task ID" do
+        expect(extract_asana_task_id("https://app.asana.com/0/0/0")).to eq("0")
+      end
 
-    it "extracts task ID when project ID is non-zero" do
-      expect(extract_asana_task_id("https://app.asana.com/0/753241/9999")).to eq("9999")
-    end
+      it "extracts task ID when project ID is non-zero" do
+        expect(extract_asana_task_id("https://app.asana.com/0/753241/9999")).to eq("9999")
+      end
 
-    it "extracts task ID when first digit is non-zero" do
-      expect(extract_asana_task_id("https://app.asana.com/4/753241/9999")).to eq("9999")
-    end
+      it "extracts long task ID" do
+        expect(extract_asana_task_id("https://app.asana.com/0/0/12837864576817392")).to eq("12837864576817392")
+      end
 
-    it "extracts long task ID" do
-      expect(extract_asana_task_id("https://app.asana.com/0/0/12837864576817392")).to eq("12837864576817392")
+      it "extracts task ID from a URL in focused mode" do
+        expect(extract_asana_task_id("https://app.asana.com/0/0/1234/f")).to eq("1234")
+      end
     end
 
-    it "extracts task ID from a URL with a trailing /f" do
-      expect(extract_asana_task_id("https://app.asana.com/0/0/1234/f")).to eq("1234")
+    context "v1 task URL" do
+      it "extracts task ID" do
+        expect(extract_asana_task_id("https://app.asana.com/1/1234/project/5678/task/9999")).to eq("9999")
+      end
+
+      it "extracts task ID when project is missing in the URL" do
+        expect(extract_asana_task_id("https://app.asana.com/1/1234/task/9999")).to eq("9999")
+      end
+
+      it "extracts long task ID" do
+        expect(extract_asana_task_id("https://app.asana.com/1/1234/task/12837864576817392")).to eq("12837864576817392")
+      end
+
+      it "extracts task ID from a URL in focused mode" do
+        expect(extract_asana_task_id("https://app.asana.com/1/1234/project/5678/task/9999?focused=true")).to eq("9999")
+      end
     end
 
     it "sets GHA output" do
@@ -46,7 +62,7 @@ def asana_task_url(task_id)
 
     it "fails when garbage is passed" do
       expect(Fastlane::UI).to receive(:user_error!)
-        .with("URL has incorrect format (attempted to match #{Fastlane::Helper::AsanaHelper::ASANA_TASK_URL_REGEX})")
+        .with("URL has incorrect format (attempted to match #{Fastlane::Helper::AsanaHelper::ASANA_V0_TASK_URL_REGEX} or #{Fastlane::Helper::AsanaHelper::ASANA_V1_TASK_URL_REGEX})")
 
       extract_asana_task_id("not a URL")
     end