Filter out inaccessible tasks when constructing release notes

Author: ayoy

lib/fastlane/plugin/ddg_apple_automation/helper/asana_helper.rb

@@ -231,6 +231,7 @@ def self.update_asana_tasks_for_internal_release(params)
 
         UI.message("Extracting task IDs from git log since #{latest_public_release.tag_name} release")
         task_ids = get_task_ids_from_git_log(latest_public_release.tag_name)
+          .filter { |task_id| validate_task_accessible(task_id, params[:asana_access_token]) }
         UI.success("#{task_ids.count} task(s) found.")
 
         UI.message("Fetching release notes from Asana release task (#{asana_task_url(params[:release_task_id])})")
@@ -428,6 +429,15 @@ def self.get_task_ids_from_git_log(from_ref, to_ref = "HEAD")
           .uniq
       end
 
+      def self.validate_task_accessible(task_id, asana_access_token)
+        asana_client = make_asana_client(asana_access_token)
+        asana_client.tasks.get_task(task_gid: task_id, options: { fields: ["gid"] })
+        true
+      rescue StandardError => e
+        UI.important("Failed to fetch #{task_id}, ignoring. Error: #{e}")
+        false
+      end
+
       def self.fetch_release_notes(release_task_id, asana_access_token, output_type: "asana")
         asana_client = make_asana_client(asana_access_token)
         release_task_body = asana_client.tasks.get_task(task_gid: release_task_id, options: { fields: ["notes"] }).notes

lib/fastlane/plugin/ddg_apple_automation/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module DdgAppleAutomation
-    VERSION = "3.0.0"
+    VERSION = "3.1.0"
   end
 end

spec/asana_helper_spec.rb

@@ -301,6 +301,7 @@ def sanitize_asana_html_notes(content)
       expect(@client).to receive(:releases).with("iOS", { page: 1, per_page: 25 })
 
       expect(Fastlane::Helper::AsanaHelper).to receive(:fetch_release_notes).with("1234567890", "secret-token")
+      expect(Fastlane::Helper::AsanaHelper).to receive(:validate_task_accessible).with("1234567890", "secret-token").and_return(true)
       expect(Fastlane::Helper::ReleaseTaskHelper).to receive(:construct_release_task_description).with("Release notes content", ["1234567890"])
       expect(Fastlane::Helper::AsanaHelper).to receive(:move_tasks_to_section).with(["1234567890", "1234567890"], "987654321", "secret-token")
       expect(Fastlane::Helper::AsanaHelper).to receive(:tag_tasks).with("tag_id", ["1234567890", "1234567890"], "secret-token")
@@ -822,4 +823,39 @@ def sanitize_asana_html_notes(content)
       Fastlane::Helper::AsanaHelper.tag_tasks(tag_id, task_ids, asana_access_token)
     end
   end
+
+  describe ".validate_task_accessible" do
+    subject { Fastlane::Helper::AsanaHelper.validate_task_accessible(task_id, asana_access_token) }
+
+    let(:task_id) { "1234567890" }
+    let(:asana_access_token) { "secret-token" }
+
+    before do
+      @asana_client = double("Asana::Client")
+      allow(Fastlane::Helper::AsanaHelper).to receive(:make_asana_client).with(asana_access_token).and_return(@asana_client)
+      allow(Fastlane::UI).to receive(:important)
+    end
+
+    context "when the task is accessible" do
+      before do
+        allow(@asana_client).to receive_message_chain(:tasks, :get_task).and_return(double(gid: task_id))
+      end
+
+      it "returns true" do
+        expect(subject).to eq(true)
+        expect(Fastlane::UI).not_to have_received(:important)
+      end
+    end
+
+    context "when the task is not accessible or fetching task data fails" do
+      before do
+        allow(@asana_client).to receive_message_chain(:tasks, :get_task).and_raise(StandardError, "API Error")
+      end
+
+      it "returns false" do
+        expect(subject).to be false
+        expect(Fastlane::UI).to have_received(:important)
+      end
+    end
+  end
 end