Add tests

Author: loremattei

lib/fastlane/plugin/ddg_apple_automation/actions/start_new_release_action.rb

@@ -21,7 +21,7 @@ def self.run(params)
             params[:github_token], params[:platform], other_action, options
           )
         else
-          release_branch_name, new_version = Helper::DdgAppleAutomationHelper.prepare_release_branch(
+          release_branch_name, new_version, update_embedded_warning = Helper::DdgAppleAutomationHelper.prepare_release_branch(
             params[:platform], params[:version], other_action
           )
         end
@@ -33,6 +33,10 @@ def self.run(params)
         options[:release_task_id] = release_task_id
 
         Helper::AsanaHelper.update_asana_tasks_for_internal_release(options) unless params[:is_hotfix]
+        Fastlane::Actions::AsanaAddCommentAction.run(
+          task_id: release_task_id,
+          comment: "TDS performance tests failed. Make sure to validate performance before releasing to public users."
+        ) if update_embedded_warning
       end
 
       def self.description

lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb

@@ -127,7 +127,7 @@ def self.prepare_release_branch(platform, version, other_action)
         code_freeze_prechecks(other_action) unless Helper.is_ci?
         new_version = validate_new_version(version)
         create_release_branch(platform, new_version)
-        update_embedded_files(platform, other_action)
+        update_embedded_result = update_embedded_files(platform, other_action)
         if platform == "ios"
           # Any time we prepare a release branch for iOS the the build number should be reset to 0
           update_version_and_build_number_config(new_version, 0, other_action)
@@ -139,7 +139,7 @@ def self.prepare_release_branch(platform, version, other_action)
         release_branch_name = release_branch_name(platform, new_version)
         Helper::GitHubActionsHelper.set_output("release_branch_name", release_branch_name)
 
-        return release_branch_name, new_version
+        return release_branch_name, new_version, update_embedded_result
       end
 
       def self.prepare_hotfix_branch(github_token, platform, other_action, options)

lib/fastlane/plugin/ddg_apple_automation/helper/embedded_files_helper.rb

@@ -27,7 +27,7 @@ class EmbeddedFilesHelper
         }.freeze
 
       def self.update_embedded_files(platform, other_action)
-        other_action.tds_perf_test
+        perf_test_warning = !other_action.tds_perf_test
         Actions.sh("./scripts/update_embedded.sh")
 
         # Verify no unexpected files were modified
@@ -50,14 +50,19 @@ def self.update_embedded_files(platform, other_action)
           Actions.sh('git', 'commit', '-m', 'Update embedded files')
           other_action.ensure_git_status_clean
         end
+
+        perf_test_warning
       end
 
       def pre_update_embedded_tests
         tds_perf_test_result = other_action.tds_perf_test
 
         unless tds_perf_test_result
-          UI.important("TDS performance tests failed. Proceeding with caution.")
+          UI.important("TDS performance tests failed. Make sure to validate performance before releasing to public users.")
+          return false
         end
+
+        return true
       end
     end
   end

spec/ddg_apple_automation_helper_spec.rb

@@ -188,6 +188,54 @@ def load_file(file)
       expect(Fastlane::Helper::GitHubActionsHelper).to have_received(:set_output).with("release_branch_name", release_branch_name)
     end
 
+    it "prepares the release branch with version updates for macOS and returns update_embedded_warning" do
+      platform = "macos"
+      version = "1.0.0"
+      release_branch_name = "release/#{platform}/#{version}"
+      other_action = double("other_action")
+      options = { some_option: "value" }
+      github_token = "github-token"
+      update_embedded_warning = true
+
+      @client = double("Octokit::Client")
+      allow(Octokit::Client).to receive(:new).and_return(@client)
+      allow(@client).to receive(:latest_release).and_return(double(tag_name: version))
+      allow(Fastlane::Helper).to receive(:is_ci?).and_return(false)
+      allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("macOS")
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:code_freeze_prechecks)
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:validate_new_version)
+        .with(version).and_return(version)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:create_release_branch)
+        .with(platform, version).and_return(release_branch_name)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:update_embedded_files)
+        .with(platform, other_action).and_return(update_embedded_warning)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:update_version_config)
+        .with(version, other_action)
+
+      allow(Fastlane::Helper::GitHubActionsHelper).to receive(:set_output)
+
+      expect(other_action).to receive(:push_to_git_remote)
+
+      result_branch, result_version, result_warning = Fastlane::Helper::DdgAppleAutomationHelper.prepare_release_branch(
+        platform, version, other_action
+      )
+
+      expect(result_branch).to eq(release_branch_name)
+      expect(result_version).to eq(version)
+      expect(result_warning).to eq(update_embedded_warning)
+
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:code_freeze_prechecks)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:validate_new_version).with(version)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:create_release_branch).with(platform, version)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_embedded_files).with(platform, other_action)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_version_config).with(version, other_action)
+      expect(Fastlane::Helper::GitHubActionsHelper).to have_received(:set_output).with("release_branch_name", release_branch_name)
+    end
+
     it "prepares the release branch with version updates for iOS" do
       platform = "ios"
       version = "1.0.0"
@@ -237,6 +285,58 @@ def load_file(file)
       expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_root_plist_version).with(version, other_action)
       expect(Fastlane::Helper::GitHubActionsHelper).to have_received(:set_output).with("release_branch_name", release_branch_name)
     end
+
+    it "prepares the release branch with version updates for iOS and returns update_embedded_warning" do
+      platform = "ios"
+      version = "1.0.0"
+      release_branch_name = "release/#{platform}/#{version}"
+      other_action = double("other_action")
+      options = { some_option: "value" }
+      github_token = "github-token"
+      update_embedded_warning = true
+
+      @client = double("Octokit::Client")
+      allow(Octokit::Client).to receive(:new).and_return(@client)
+      allow(@client).to receive(:latest_release).and_return(double(tag_name: version))
+      allow(Fastlane::Helper).to receive(:is_ci?).and_return(false)
+      allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("iOS")
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:code_freeze_prechecks)
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:validate_new_version)
+        .with(version).and_return(version)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:create_release_branch)
+        .with(platform, version).and_return(release_branch_name)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:update_embedded_files)
+        .with(platform, other_action).and_return(update_embedded_warning)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:update_version_and_build_number_config)
+        .with(version, 0, other_action)
+
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:update_root_plist_version)
+        .with(version, other_action)
+
+      allow(Fastlane::Helper::GitHubActionsHelper).to receive(:set_output)
+
+      expect(other_action).to receive(:push_to_git_remote)
+
+      result_branch, result_version, result_warning = Fastlane::Helper::DdgAppleAutomationHelper.prepare_release_branch(
+        platform, version, other_action
+      )
+
+      expect(result_branch).to eq("release/ios/1.0.0")
+      expect(result_version).to eq(version)
+      expect(result_warning).to eq(update_embedded_warning)
+
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:code_freeze_prechecks)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:validate_new_version).with(version)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:create_release_branch).with(platform, version)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_embedded_files).with(platform, other_action)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_version_and_build_number_config).with(version, 0, other_action)
+      expect(Fastlane::Helper::DdgAppleAutomationHelper).to have_received(:update_root_plist_version).with(version, other_action)
+      expect(Fastlane::Helper::GitHubActionsHelper).to have_received(:set_output).with("release_branch_name", release_branch_name)
+    end
   end
 
   describe "#create_hotfix_branch" do
@@ -417,6 +517,40 @@ def load_file(file)
       expect(Fastlane::Actions).to have_received(:sh).with("git", "add", "Core/trackerData.json")
       expect(Fastlane::Actions).to have_received(:sh).with("git", "commit", "-m", "Update embedded files")
     end
+
+    it "returns true when TDS performance tests fail" do      
+      allow(Fastlane::Actions).to receive(:sh).with("./scripts/update_embedded.sh").and_return("")
+      git_status_output = "On branch main\nmodified: Core/trackerData.json\n"
+      allow(Fastlane::Actions).to receive(:sh).with("git", "status").and_return(git_status_output)
+      allow(Fastlane::Actions).to receive(:sh).with("git", "add", "Core/trackerData.json").and_return("")
+      allow(Fastlane::Actions).to receive(:sh).with("git", "commit", "-m", "Update embedded files").and_return("")
+      allow(other_action).to receive(:tds_perf_test).and_return(false)
+      allow(other_action).to receive(:ensure_git_status_clean)
+      
+      result = described_class.update_embedded_files(platform, other_action)
+      
+      expect(result).to eq(true)
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "status")
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "add", "Core/trackerData.json")
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "commit", "-m", "Update embedded files")
+    end
+    
+    it "returns false when TDS performance tests pass" do
+      allow(Fastlane::Actions).to receive(:sh).with("./scripts/update_embedded.sh").and_return("")
+      git_status_output = "On branch main\nmodified: Core/trackerData.json\n"
+      allow(Fastlane::Actions).to receive(:sh).with("git", "status").and_return(git_status_output)
+      allow(Fastlane::Actions).to receive(:sh).with("git", "add", "Core/trackerData.json").and_return("")
+      allow(Fastlane::Actions).to receive(:sh).with("git", "commit", "-m", "Update embedded files").and_return("")
+      allow(other_action).to receive(:tds_perf_test).and_return(true)
+      allow(other_action).to receive(:ensure_git_status_clean)
+
+      result = described_class.update_embedded_files(platform, other_action)
+      
+      expect(result).to eq(false)
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "status")
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "add", "Core/trackerData.json")
+      expect(Fastlane::Actions).to have_received(:sh).with("git", "commit", "-m", "Update embedded files")
+    end
   end
 
   describe "#increment_build_number" do

spec/start_new_release_action_spec.rb

@@ -79,6 +79,28 @@
           )
         )
       end
+
+      it 'doesn\'t warn on TDS performance tests success' do
+        subject
+        expect(Fastlane::Actions::AsanaAddCommentAction).not_to receive(:run)
+      end
+
+      context "on TDS performance tests failure" do
+        before do
+          allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:prepare_release_branch).and_return(["release_branch_name", "1.1.0", true])
+          allow(Fastlane::Actions::AsanaAddCommentAction).to receive(:run)
+        end
+        it 'warns about TDS performance tests failures' do
+          
+          subject
+          expect(Fastlane::Actions::AsanaAddCommentAction).to have_received(:run).with(
+            hash_including(
+              task_id: "1234567890",
+              comment: include("TDS performance tests failed")
+            )
+          )
+        end
+      end
     end
 
     context "on macos" do