Adding reference change

Author: jonathanKingston

features/element-hiding.json

@@ -13,7 +13,7 @@
         }
     ],
     "settings": {
-        "useStrictHideStyleTag": true,
+        "useStrictHideStyleTag2": true,
         "rules": [
             {
                 "selector": "[id*='gpt-']",

index.js

@@ -11,12 +11,14 @@ const {
     getBaseFeatureConfigs,
 } = require('./util');
 
+const immutableJSONPatch = require('immutable-json-patch').immutableJSONPatch;
+
 const { OVERRIDE_DIR, GENERATED_DIR, LISTS_DIR, BROWSERS_SUBDIR, CURRENT_CONFIG_VERSION, UNPROTECTED_LIST_NAME } = require('./constants');
 
 const defaultConfig = {
     readme: 'https://github.com/duckduckgo/privacy-configuration',
     version: Date.now(),
-    meta: {
+    reference: {
         features: getBaseFeatureConfigs(),
     },
     unprotectedTemporary: [],
@@ -81,7 +83,7 @@ function writeConfigToDisk(platform, config) {
         addHashToFeatures(compatConfig);
 
         compatibility.removeEolFeatures(compatConfig, i);
-        fs.writeFileSync(`${GENERATED_DIR}/${version}/${configName}-config.json`, JSON.stringify(compatConfig));
+        fs.writeFileSync(`${GENERATED_DIR}/${version}/${configName}-config.json`, JSON.stringify(compatConfig, null, 2));
     }
 }
 
@@ -257,6 +259,15 @@ async function buildPlatforms() {
             if (isFeatureMissingState(platformConfig.features[key])) {
                 platformConfig.features[key].state = 'disabled';
             }
+            const feature = platformConfig.features[key];
+            feature.reference = defaultConfig.reference;
+            if ('patchFeature' in feature) {
+                console.log(`Patching feature ${key} for ${platform}`, feature.patchFeature, JSON.stringify(platformOverride.features[key], null, 2), JSON.stringify(defaultConfig.reference.features[key], null, 2));
+                platformConfig.features[key] = immutableJSONPatch(feature, feature.patchFeature);
+                console.log('Patching feature', platformConfig.features[key]);
+            }
+            delete feature.patchFeature;
+            delete feature.reference;
         }
 
         // Remove appTP feature from platforms that don't use it since it's a large feature
@@ -279,6 +290,7 @@ async function buildPlatforms() {
 
         addCnameEntriesToAllowlist(tds, platformConfig.features.trackerAllowlist.settings.allowlistedTrackers);
         platformConfig = inlineReasonArrays(platformConfig);
+        delete platformConfig.reference;
         platformConfigs[platform] = platformConfig;
 
         // Write config to disk

overrides/android-override.json

@@ -621,7 +621,15 @@
             }
         },
         "elementHiding": {
-            "state": "enabled"
+            "state": "enabled",
+            "patchFeature": [
+                {
+                    "op": "copy",
+                    "from": "/reference/elementHiding/settings/rules",
+                    "path": "/settings"
+                }
+            ],
+            "settings": {}
         },
         "breakageReporting": {
             "state": "enabled"

overrides/extension-override.json

@@ -58,7 +58,15 @@
             "state": "enabled"
         },
         "elementHiding": {
-            "state": "enabled"
+            "state": "enabled",
+            "patchFeature": [
+                {
+                    "op": "copy",
+                    "from": "/reference/elementHiding/settings/rules",
+                    "path": "/settings"
+                }
+            ],
+            "settings": {}
         },
         "fingerprintingCanvas": {
             "state": "disabled"

overrides/ios-override.json

@@ -321,7 +321,15 @@
             "state": "enabled"
         },
         "elementHiding": {
-            "state": "enabled"
+            "state": "enabled",
+            "patchFeature": [
+                {
+                    "op": "copy",
+                    "from": "/reference/elementHiding/settings/rules",
+                    "path": "/settings"
+                }
+            ],
+            "settings": {}
         },
         "autoconsent": {
             "state": "enabled",

overrides/macos-override.json

@@ -297,7 +297,15 @@
                     "domain": "wunderground.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
                 }
-            ]
+            ],
+            "patchFeature": [
+                {
+                    "op": "copy",
+                    "from": "/reference/elementHiding/settings/rules",
+                    "path": "/settings"
+                }
+            ],
+            "settings": {}
         },
         "gpc": {
             "state": "enabled"

overrides/windows-override.json

@@ -174,7 +174,15 @@
             }
         },
         "elementHiding": {
-            "state": "enabled"
+            "state": "enabled",
+            "patchFeature": [
+                {
+                    "op": "copy",
+                    "from": "/reference/elementHiding/settings/rules",
+                    "path": "/settings"
+                }
+            ],
+            "settings": {}
         },
         "fingerprintingScreenSize": {
             "state": "disabled",