Merge pull request Expensify#96506 from callstack-internal/pmr-fail-on-server-commit

fix: positively recognize "already paid" server rejection

Author: carlosmiceli

src/CONST/index.ts

@@ -2515,6 +2515,7 @@ const CONST = {
         SOCKET: 'Issue connecting to database',
         DUPLICATE_RECORD: '400 Unique Constraints Violation',
         ALREADY_CREATED_TRANSACTION: 'Transaction already created.',
+        ALREADY_PAID: 'The request has already been paid',
     },
     NETWORK: {
         METHOD: {

src/libs/HttpUtils.ts

@@ -57,7 +57,7 @@ const addSkewList = new Set<string>([WRITE_COMMANDS.OPEN_REPORT, SIDE_EFFECT_REQ
  * Per-command server response messages we recognize as the PHP-wrapped "AlreadyCreated" error.
  * Add new variants here as we discover them for other non-idempotent commands.
  */
-const ALREADY_CREATED_MESSAGES = new Set<string>([CONST.ERROR_TITLE.ALREADY_CREATED_TRANSACTION]);
+const ALREADY_CREATED_MESSAGES = new Set<string>([CONST.ERROR_TITLE.ALREADY_CREATED_TRANSACTION, CONST.ERROR_TITLE.ALREADY_PAID]);
 
 /**
  * Regex to get API command from the command

tests/unit/HttpUtilsTest.ts

@@ -0,0 +1,50 @@
+import {WRITE_COMMANDS} from '@libs/API/types';
+
+import CONST from '@src/CONST';
+import ONYXKEYS from '@src/ONYXKEYS';
+
+import Onyx from 'react-native-onyx';
+
+import HttpUtils from '../../src/libs/HttpUtils';
+
+function mockFetchResponse(message: string) {
+    global.fetch = jest.fn().mockResolvedValue({
+        ok: true,
+        status: 200,
+        headers: {get: () => null},
+        json: () => Promise.resolve({jsonCode: CONST.JSON_CODE.EXP_ERROR, message}),
+    });
+}
+
+beforeAll(() => {
+    Onyx.init({
+        keys: ONYXKEYS,
+    });
+});
+
+afterEach(() => {
+    jest.restoreAllMocks();
+});
+
+describe('HttpUtils', () => {
+    // The mapping is keyed on the server message alone, not the command. The messages are
+    // pinned as literals so a change to the CONST values can't silently drift from what the
+    // server really sends.
+    it.each([
+        ['Transaction already created.', WRITE_COMMANDS.REQUEST_MONEY],
+        ['The request has already been paid', WRITE_COMMANDS.PAY_MONEY_REQUEST],
+    ])('maps the jsonCode-666 rejection "%s" to ALREADY_CREATED', async (message, command) => {
+        mockFetchResponse(message);
+
+        await expect(HttpUtils.xhr(command, {})).rejects.toMatchObject({
+            message: CONST.ERROR.ALREADY_CREATED,
+            title: message,
+        });
+    });
+
+    it('leaves a jsonCode-666 response with an unrecognized message untouched', async () => {
+        mockFetchResponse('Some other error');
+
+        await expect(HttpUtils.xhr(WRITE_COMMANDS.PAY_MONEY_REQUEST, {})).resolves.toMatchObject({jsonCode: CONST.JSON_CODE.EXP_ERROR, message: 'Some other error'});
+    });
+});