Commit 57bc149
committed
surreal: improve schema generation and error handling
Body
- Add `responseMessage(JsonNode)` helper and use it to produce clearer, robust error messages when parsing SurrealDB `info()` responses.
- Harden exec/execThenSaveHistory to check presence/type of `status` and to raise errors using `responseMessage` instead of assuming keys.
- Treat Surreal `id` field as a special case: skip generating autoincrement definitions for `id` (avoid defining increments on Surreal primary id) and adjust createIncrements/createInt behavior.
- Map Surreal `object` type to Nim `JsonNode` in `create_schema` generation.
- Update test `tests/surrealdb/test_create_schema.nim` to use `index` as the increments column in fixtures and assert generated schema accordingly.
- Files changed: src/allographer/schema_builder/queries/surreal/schema_utils.nim, src/allographer/schema_builder/queries/surreal/sub/create_column_query.nim, src/allographer/schema_builder/usecases/surreal/create_schema.nim, tests/surrealdb/test_create_schema.nim.
Rationale
Improve robustness when consuming SurrealDB metadata and ensure generated Nim schema/types and column-definition SQL are consistent and safe for common edge cases.1 parent f722475 commit 57bc149
4 files changed
Lines changed: 30 additions & 7 deletions
File tree
- src/allographer/schema_builder
- queries/surreal
- sub
- usecases/surreal
- tests/surrealdb
Lines changed: 16 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
23 | 34 | | |
24 | 35 | | |
25 | 36 | | |
| |||
60 | 71 | | |
61 | 72 | | |
62 | 73 | | |
63 | | - | |
64 | | - | |
| 74 | + | |
| 75 | + | |
65 | 76 | | |
66 | 77 | | |
67 | 78 | | |
| |||
91 | 102 | | |
92 | 103 | | |
93 | 104 | | |
94 | | - | |
| 105 | + | |
95 | 106 | | |
96 | | - | |
97 | | - | |
| 107 | + | |
| 108 | + | |
98 | 109 | | |
99 | 110 | | |
100 | 111 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
54 | 61 | | |
55 | 62 | | |
56 | 63 | | |
| |||
67 | 74 | | |
68 | 75 | | |
69 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
70 | 80 | | |
71 | 81 | | |
72 | 82 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
| 70 | + | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
0 commit comments