Skip to content

Commit 2fc0afb

Browse files
committed
[chore] cleanup
1 parent dd3adbb commit 2fc0afb

5 files changed

Lines changed: 14 additions & 33 deletions

File tree

.github/workflows/ci-container.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ jobs:
6060
REVISION_ARG="-Drevision=${VERSION#eXist-}"
6161
fi
6262
mvn -V -B --no-transfer-progress -q \
63-
-Pdocker -DskipTests -Ddependency-check.skip=true \
64-
-P '!mac-dmg-on-unix,skip-build-dist-archives' \
63+
-Pdocker,skip-build-dist-archives \
64+
-DskipTests -Ddependency-check.skip=true \
6565
$REVISION_ARG \
6666
clean package
6767
- name: Check local images

AGENTS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ eXist-db is an open-source native XML database with full XQuery support. The mai
1717
```bash
1818
JAVA_HOME=$(/usr/libexec/java_home -v 21) \
1919
mvn -T1.5C clean install -DskipTests -Ddependency-check.skip=true -Ddocker=false \
20-
-P 'skip-build-dist-archives,!build-dist-archives,!mac-dmg-on-mac,!codesign-mac-dmg,!mac-dmg-on-unix,!installer,!concurrency-stress-tests,!micro-benchmarks,!appassembler-booter'
20+
-Pskip-build-dist-archives
2121
```
2222

23+
On macOS this still produces an unsigned DMG (`mac-dmg-on-mac` is active by default on Mac runners). Add `-P '!mac-dmg-on-mac'` to skip it.
24+
2325
### Build a single module
2426

2527
```bash
@@ -61,12 +63,10 @@ The DMG is unsigned. For the fully signed and notarized DMG used in releases, se
6163
### IzPack installer JAR
6264

6365
Produces the cross-platform installer JAR in `exist-installer/target/`.
64-
Maven will warn "could not be activated because it does not exist" for the `installer` profile — this is a Maven 3 multi-module quirk; the build is correct.
6566

6667
```bash
6768
JAVA_HOME=$(/usr/libexec/java_home -v 21) \
6869
mvn -T1.5C clean package \
69-
-Pinstaller \
7070
-pl exist-installer -am \
7171
-DskipTests \
7272
-Ddependency-check.skip=true \
@@ -81,7 +81,7 @@ Run the installer: `java -jar exist-installer/target/exist-installer-7.0.0-SNAPS
8181
```bash
8282
# Build the Docker image
8383
mvn -T1.5C clean package -DskipTests -Ddependency-check.skip=true -Ddocker=true \
84-
-P 'skip-build-dist-archives,!build-dist-archives,!mac-dmg-on-mac,!codesign-mac-dmg,!mac-dmg-on-unix,!installer,!concurrency-stress-tests,!micro-benchmarks,!appassembler-booter' \
84+
-Pskip-build-dist-archives \
8585
-pl exist-docker -am
8686

8787
cp exist-docker/target/classes/Dockerfile exist-docker/target/exist-docker-*-docker-dir/Dockerfile

exist-distribution/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -968,6 +968,9 @@
968968

969969
<profiles>
970970
<profile>
971+
<!-- Shares the `onnx-model` id with exist-parent's profile so that a single
972+
`-Ponnx-model` activates the model download (in parent) AND adds the
973+
exist-vector runtime dependency (here). Keep ids in sync. -->
971974
<id>onnx-model</id>
972975
<dependencies>
973976
<dependency>

exist-versioning-release.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ The `ci-release.yml` workflow runs four jobs in parallel then converges:
117117

118118
### Prerequisites: required GitHub secrets and repository rules
119119

120-
All secrets must be in place under **Settings → Secrets and variables → Actions** before running a release. See `plans/internal-release-runbook.template.md` for the full table and rotation guidance.
120+
All secrets must be in place under **Settings → Secrets and variables → Actions** before running a release. See `internal-release-runbook.template.md` for the full table and rotation guidance.
121121

122122
A **tag ruleset** restricts creation and deletion of `eXist-*` tags to users with the Maintain or Admin role (Settings → Rules → Rulesets). The `RELEASE_PAT` owner must hold one of those roles; all other automation only reads tags and is unaffected.
123123

pom.xml

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -74,30 +74,23 @@
7474
<!-- === Build umbrella profiles === -->
7575
<profile>
7676
<!-- Default contributor build: compiles, tests, produces a runnable distribution dir.
77-
Does NOT build installer, stress tests, or micro-benchmarks. -->
77+
Does NOT build installer or perf modules. -->
7878
<id>local-build</id>
7979
<activation>
8080
<activeByDefault>true</activeByDefault>
8181
</activation>
8282
</profile>
8383

8484
<profile>
85-
<!-- Full release build: adds exist-installer to the reactor and sets exist.release=true
86-
to enable dist archive assembly in exist-distribution. Use with -Prelease-build. -->
85+
<!-- Full release build: adds exist-installer to the reactor and (via exist-parent's
86+
release-build profile) enables GPG signing + Central publishing. -->
8787
<id>release-build</id>
8888
<modules>
8989
<module>exist-installer</module>
9090
</modules>
9191
</profile>
9292
<!-- === End Build umbrella profiles === -->
9393

94-
<profile>
95-
<id>installer</id>
96-
<modules>
97-
<module>exist-installer</module>
98-
</modules>
99-
</profile>
100-
10194
<profile>
10295
<id>docker</id>
10396
<activation>
@@ -112,7 +105,7 @@
112105
</profile>
113106

114107
<profile>
115-
<!-- Activates both stress tests and micro-benchmarks in one shot: -Pperf-tests -->
108+
<!-- Stress tests + JMH micro-benchmarks. -->
116109
<id>perf-tests</id>
117110
<modules>
118111
<module>exist-core-jcstress</module>
@@ -121,21 +114,6 @@
121114
</modules>
122115
</profile>
123116

124-
<profile>
125-
<id>concurrency-stress-tests</id>
126-
<modules>
127-
<module>exist-core-jcstress</module>
128-
</modules>
129-
</profile>
130-
131-
<profile>
132-
<id>micro-benchmarks</id>
133-
<modules>
134-
<module>exist-core-jmh</module>
135-
<module>exist-indexes-jmh</module>
136-
</modules>
137-
</profile>
138-
139117
<profile>
140118
<id>citation-release-metadata</id>
141119
<activation>

0 commit comments

Comments
 (0)