Skip to content

Commit 8a199bb

Browse files
committed
chore: remove useless EDANT_WATCHER_VERSION Docker ARG
1 parent fd49ead commit 8a199bb

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

dev-alpine.Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ RUN git clone --branch=PHP-8.4 https://github.com/php/php-src.git . && \
6565
php --version
6666

6767
# Install e-dant/watcher (necessary for file watching)
68-
ARG EDANT_WATCHER_VERSION=release
6968
WORKDIR /usr/local/src/watcher
70-
RUN git clone --branch=$EDANT_WATCHER_VERSION https://github.com/e-dant/watcher . && \
69+
RUN git clone https://github.com/e-dant/watcher . && \
7170
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release && \
7271
cmake --build build/ && \
7372
cmake --install build

dev.Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@ RUN git clone --branch=PHP-8.4 https://github.com/php/php-src.git . && \
6767
php --version
6868

6969
# Install e-dant/watcher (necessary for file watching)
70-
ARG EDANT_WATCHER_VERSION=release
7170
WORKDIR /usr/local/src/watcher
72-
RUN git clone --branch=$EDANT_WATCHER_VERSION https://github.com/e-dant/watcher . && \
71+
RUN git clone https://github.com/e-dant/watcher . && \
7372
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release && \
7473
cmake --build build/ && \
7574
cmake --install build

docker-bake.hcl

-6
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ variable "GO_VERSION" {
1414
default = "1.23"
1515
}
1616

17-
variable EDANT_WATCHER_VERSION {
18-
default = "next"
19-
}
20-
2117
variable "SHA" {}
2218

2319
variable "LATEST" {
@@ -119,7 +115,6 @@ target "default" {
119115
}
120116
args = {
121117
FRANKENPHP_VERSION = VERSION
122-
EDANT_WATCHER_VERSION = EDANT_WATCHER_VERSION
123118
}
124119
}
125120

@@ -145,7 +140,6 @@ target "static-builder" {
145140
}
146141
args = {
147142
FRANKENPHP_VERSION = VERSION
148-
EDANT_WATCHER_VERSION = EDANT_WATCHER_VERSION
149143
}
150144
secret = ["id=github-token,env=GITHUB_TOKEN"]
151145
}

0 commit comments

Comments
 (0)