Skip to content

Metrics is missing on frankenphp >= 1.4.0 #1365

Open
@IndraGunawan

Description

What happened?

frankenphp_* metrics were there before v1.4.0

I did a quick debug and found out that caddy 2.9 changed the flow of how the module should hook to use the metrics registry

var metrics = frankenphp.NewPrometheusMetrics(prometheus.DefaultRegisterer)
current frankenphp implementation is still relying on this caddyserver/caddy#3709 but in caddyserver/caddy@41f5dd5 (caddy v2.9.0) changed the flow to get the metrics registry

Build Type

Docker (Debian Bookworm)

Worker Mode

Yes

Operating System

GNU/Linux

CPU Architecture

x86_64

PHP configuration

-

Relevant log output

-

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions