perf: various optimizations

Author: dunglas

event.go

@@ -5,6 +5,9 @@ import (
 	"strings"
 )
 
+//nolint:gochecknoglobals
+var dataReplacer = strings.NewReplacer("\r\n", "\ndata: ", "\r", "\ndata: ", "\n", "\ndata: ")
+
 // Event is the actual Server Sent Event that will be dispatched.
 type Event struct {
 	// The updates' data, encoded in the sever-sent event format: every line starts with the string "data: "
@@ -33,8 +36,7 @@ func (e *Event) String() string {
 		_, _ = fmt.Fprintf(&b, "retry: %d\n", e.Retry)
 	}
 
-	r := strings.NewReplacer("\r\n", "\ndata: ", "\r", "\ndata: ", "\n", "\ndata: ")
-	_, _ = fmt.Fprintf(&b, "id: %s\ndata: %s\n\n", e.ID, r.Replace(e.Data))
+	_, _ = fmt.Fprintf(&b, "id: %s\ndata: %s\n\n", e.ID, dataReplacer.Replace(e.Data))
 
 	return b.String()
 }

subscriber.go

@@ -59,6 +59,10 @@ func (s *Subscriber) MatchTopics(topics []string, private bool) bool {
 				if s.topicSelectorStore.match(topic, ts) {
 					subscribed = true
 
+					if canAccess {
+						return true
+					}
+
 					break
 				}
 			}
@@ -69,6 +73,10 @@ func (s *Subscriber) MatchTopics(topics []string, private bool) bool {
 				if s.topicSelectorStore.match(topic, ts) {
 					canAccess = true
 
+					if subscribed {
+						return true
+					}
+
 					break
 				}
 			}

topicselector.go

@@ -26,8 +26,15 @@ func (tss *TopicSelectorStore) match(topic, topicSelector string) bool {
 	}
 
 	var k string
+
 	if tss.cache != nil {
-		k = "m_" + topicSelector + "_" + topic
+		var b strings.Builder
+		b.Grow(3 + len(topicSelector) + len(topic))
+		b.WriteString("m_")
+		b.WriteString(topicSelector)
+		b.WriteByte('_')
+		b.WriteString(topic)
+		k = b.String()
 
 		value, found := tss.cache.Get(k)
 		if found {