fix: remove unnecessary try catch

Author: dungngminh

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.2.2
+
+- fix: remove unnecessary try catch
+
 ## 1.2.1+3
 
 - chore: add more docs for API

lib/src/sheet_remote_config.dart

@@ -135,12 +135,8 @@ class SheetRemoteConfig {
   /// ```
   /// {@endtemplate}
   String? getString(String key, {String? defaultValue}) {
-    try {
-      final valueAtKey = _inMemoryCachedConfig[key];
-      return valueAtKey ?? defaultValue;
-    } catch (e) {
-      return defaultValue;
-    }
+    final valueAtKey = _inMemoryCachedConfig[key];
+    return valueAtKey ?? defaultValue;
   }
 
   /// Return the value of the given key from the in-memory cache as a [bool].
@@ -149,17 +145,13 @@ class SheetRemoteConfig {
   ///
   /// {@macro get_value}
   bool? getBool(String key, {bool? defaultValue}) {
-    try {
-      final value = _inMemoryCachedConfig[key];
-      if (value == null && value!.isEmpty) return defaultValue;
-      final boolValue = bool.tryParse(
-        value,
-        caseSensitive: false,
-      );
-      return boolValue ?? defaultValue;
-    } catch (e) {
-      return defaultValue;
-    }
+    final valueAtKey = _inMemoryCachedConfig[key];
+    if (valueAtKey == null || valueAtKey.isEmpty) return defaultValue;
+    final boolValue = bool.tryParse(
+      valueAtKey,
+      caseSensitive: false,
+    );
+    return boolValue ?? defaultValue;
   }
 
   /// Return the value of the given key from the in-memory cache as an [int].
@@ -168,14 +160,10 @@ class SheetRemoteConfig {
   ///
   /// {@macro get_value}
   int? getInt(String key, {int? defaultValue}) {
-    try {
-      final valueAtKey = _inMemoryCachedConfig[key];
-      if (valueAtKey == null && valueAtKey!.isEmpty) return defaultValue;
-      final intValue = int.tryParse(valueAtKey);
-      return intValue ?? defaultValue;
-    } catch (e) {
-      return defaultValue;
-    }
+    final valueAtKey = _inMemoryCachedConfig[key];
+    if (valueAtKey == null || valueAtKey.isEmpty) return defaultValue;
+    final intValue = int.tryParse(valueAtKey);
+    return intValue ?? defaultValue;
   }
 
   /// Return the value of the given key from the in-memory cache as a [double].
@@ -184,14 +172,10 @@ class SheetRemoteConfig {
   ///
   /// {@macro get_value}
   double? getDouble(String key, {double? defaultValue}) {
-    try {
-      final valueAtKey = _inMemoryCachedConfig[key];
-      if (valueAtKey == null && valueAtKey!.isEmpty) return defaultValue;
-      final doubleValue = double.tryParse(valueAtKey);
-      return doubleValue ?? defaultValue;
-    } catch (e) {
-      return defaultValue;
-    }
+    final valueAtKey = _inMemoryCachedConfig[key];
+    if (valueAtKey == null || valueAtKey.isEmpty) return defaultValue;
+    final doubleValue = double.tryParse(valueAtKey);
+    return doubleValue ?? defaultValue;
   }
 
   /// Return all the values from the in-memory cache.

pubspec.lock

@@ -5,23 +5,23 @@ packages:
     dependency: transitive
     description:
       name: _fe_analyzer_shared
-      sha256: "16e298750b6d0af7ce8a3ba7c18c69c3785d11b15ec83f6dcd0ad2a0009b3cab"
+      sha256: "45cfa8471b89fb6643fe9bf51bd7931a76b8f5ec2d65de4fb176dba8d4f22c77"
       url: "https://pub.dev"
     source: hosted
-    version: "76.0.0"
+    version: "73.0.0"
   _macros:
     dependency: transitive
     description: dart
     source: sdk
-    version: "0.3.3"
+    version: "0.3.2"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
-      sha256: "1f14db053a8c23e260789e9b0980fa27f2680dd640932cae5e1137cce0e46e1e"
+      sha256: "4959fec185fe70cce007c57e9ab6983101dbe593d2bf8bbfb4453aaec0cf470a"
       url: "https://pub.dev"
     source: hosted
-    version: "6.11.0"
+    version: "6.8.0"
   args:
     dependency: transitive
     description:
@@ -194,10 +194,10 @@ packages:
     dependency: "direct dev"
     description:
       name: lints
-      sha256: c35bb79562d980e9a453fc715854e1ed39e24e7d0297a880ef54e17f9874a9d7
+      sha256: "3315600f3fb3b135be672bf4a178c55f274bebe368325ae18462c89ac1e3b413"
       url: "https://pub.dev"
     source: hosted
-    version: "5.1.1"
+    version: "5.0.0"
   logging:
     dependency: transitive
     description:
@@ -210,10 +210,10 @@ packages:
     dependency: transitive
     description:
       name: macros
-      sha256: "1d9e801cd66f7ea3663c45fc708450db1fa57f988142c64289142c9b7ee80656"
+      sha256: "0acaed5d6b7eab89f63350bccd82119e6c602df0f391260d0e32b5e23db79536"
       url: "https://pub.dev"
     source: hosted
-    version: "0.1.3-main.0"
+    version: "0.1.2-main.4"
   matcher:
     dependency: transitive
     description:
@@ -242,10 +242,10 @@ packages:
     dependency: "direct dev"
     description:
       name: mockito
-      sha256: f99d8d072e249f719a5531735d146d8cf04c580d93920b04de75bef6dfb2daf6
+      sha256: "6841eed20a7befac0ce07df8116c8b8233ed1f4486a7647c7fc5a02ae6163917"
       url: "https://pub.dev"
     source: hosted
-    version: "5.4.5"
+    version: "5.4.4"
   node_preamble:
     dependency: transitive
     description:

pubspec.yaml

@@ -1,6 +1,6 @@
 name: dart_gsheet_remote_config
 description: A package that allows you to use Google Sheets as a remote config for changing your Dart/Flutter app's behaviors, settings,.. without updating.
-version: 1.2.1+3
+version: 1.2.2
 topics: [remote, config]
 repository: https://github.com/dungngminh/dart_gsheet_remote_config