Fix SelectMenuTile styling (#988)

Author: Pante

forui/CHANGELOG.md

@@ -45,6 +45,12 @@
   `FTypography.extensions`.
 
 
+## 0.21.2
+
+### `FSelectMenuTile`
+* Fix `FSelectMenuTile` rendering an extra border when a custom style is supplied inside a `FTileGroup`.
+
+
 ## 0.21.1
 
 ### `FHeader`

forui/lib/src/widgets/select_menu_tile.dart

@@ -579,12 +579,11 @@ class _FSelectMenuTileState<T> extends State<FSelectMenuTile<T>> with TickerProv
     final inheritedStyle = FTileGroupStyleData.maybeOf(context);
 
     final global = context.theme.selectMenuTileStyle;
-    final selectMenuTileStyle = widget.style(global);
+    final base = inheritedStyle == null ? global : global.copyWith(tileStyle: inheritedStyle.tileStyles.primary);
+    final selectMenuTileStyle = widget.style(base);
 
     final menuStyle = selectMenuTileStyle.menuStyle;
-    final tileStyle = widget.style == const .context()
-        ? (inheritedStyle?.tileStyles.primary ?? global.tileStyle)
-        : selectMenuTileStyle.tileStyle;
+    final tileStyle = selectMenuTileStyle.tileStyle;
 
     return MultiValueFormField<T>(
       key: widget.formFieldKey,

forui/test/src/widgets/select_menu_tile/select_menu_tile_test.dart

@@ -197,6 +197,44 @@ void main() {
     expect(find.text('Item 2'), findsOne);
   });
 
+  testWidgets('.delta() style inside FTileGroup inherits group tile style', (tester) async {
+    // https://github.com/duobaseio/forui/issues/984
+    // A no-op .delta() should yield the same inner tile style as .context()
+    // when FSelectMenuTile is nested inside a FTileGroup.
+    await tester.pumpWidget(
+      TestScaffold.app(
+        child: FTileGroup(
+          label: const Text('label'),
+          children: [
+            FSelectMenuTile<int>(
+              title: const Text('title'),
+              menu: const [.tile(title: Text('1'), value: 1)],
+            ),
+          ],
+        ),
+      ),
+    );
+    final contextStyle = tester.widget<FTile>(find.byType(FTile)).style;
+
+    await tester.pumpWidget(
+      TestScaffold.app(
+        child: FTileGroup(
+          label: const Text('label'),
+          children: [
+            FSelectMenuTile<int>(
+              title: const Text('title'),
+              style: const .delta(),
+              menu: const [.tile(title: Text('1'), value: 1)],
+            ),
+          ],
+        ),
+      ),
+    );
+    final deltaStyle = tester.widget<FTile>(find.byType(FTile)).style;
+
+    expect(deltaStyle, contextStyle);
+  });
+
   testWidgets('selecting item in menu closes it', (tester) async {
     await tester.pumpWidget(
       TestScaffold.app(