Fix FSelect onChange not firing when clearing via clear button (#950)

Closes #947

Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>

Author: Pante

forui/CHANGELOG.md

@@ -65,6 +65,12 @@ We've adjusted `FDialog`'s styling to be more visually pleasing on touch devices
 * Fix portal not repositioning when the child widget changes size.
 
 
+## 0.20.4
+
+### `FSelect`
+* Fix `onChange` not being called when clearing via the clear button.
+
+
 ## 0.20.3
 
 ### `FToaster`

forui/lib/src/widgets/select/single/select.dart

@@ -743,6 +743,7 @@ abstract class _State<S extends FSelect<T>, T> extends State<S> with TickerProvi
       return;
     }
 
+    final previous = _controller.value;
     try {
       _mutating = true;
       if (_textController.text.isEmpty) {
@@ -751,6 +752,12 @@ abstract class _State<S extends FSelect<T>, T> extends State<S> with TickerProvi
     } finally {
       _mutating = false;
     }
+
+    if (previous != _controller.value) {
+      if (widget.control case FSelectManagedControl(:final onChange?)) {
+        onChange(_controller.value);
+      }
+    }
   }
 
   void _updateTextController() {

forui/pubspec.yaml

@@ -1,6 +1,6 @@
 name: forui
 description: Beautifully designed, minimalistic widgets for desktop & touch devices.
-version: 0.20.3
+version: 0.20.4
 homepage: https://forui.dev/
 documentation: https://forui.dev/docs
 repository: https://github.com/duobaseio/forui/tree/main/forui

forui/test/src/widgets/date_field/input/input_date_field_test.dart

@@ -45,6 +45,31 @@ void main() {
 
         expect(changed, DateTime.utc(2025, 1, 15));
       });
+
+      testWidgets('onChange called when clearing via clear button', (tester) async {
+        final values = <DateTime?>[];
+
+        await tester.pumpWidget(
+          TestScaffold.app(
+            locale: const Locale('en', 'SG'),
+            child: FDateField.input(
+              key: key,
+              clearable: true,
+              control: .managed(onChange: values.add),
+            ),
+          ),
+        );
+
+        await tester.enterText(find.byKey(key), '15/01/2025');
+        await tester.pumpAndSettle();
+
+        expect(values, [DateTime.utc(2025, 1, 15)]);
+
+        await tester.tap(find.bySemanticsLabel('Clear'));
+        await tester.pumpAndSettle();
+
+        expect(values, [DateTime.utc(2025, 1, 15), null]);
+      });
     });
 
     group('lifted', () {

forui/test/src/widgets/select/single/select_test.dart

@@ -153,6 +153,35 @@ void main() {
       await tester.pumpWidget(const SizedBox());
     });
 
+    testWidgets('onChange called when clearing via clear button', (tester) async {
+      String? value = 'A';
+      final values = <String?>[];
+
+      await tester.pumpWidget(
+        TestScaffold.app(
+          child: StatefulBuilder(
+            builder: (context, setState) => FSelect<String>(
+              key: key,
+              clearable: true,
+              control: .lifted(
+                value: value,
+                onChange: (v) => setState(() {
+                  value = v;
+                  values.add(v);
+                }),
+              ),
+              items: letters,
+            ),
+          ),
+        ),
+      );
+
+      await tester.tap(find.bySemanticsLabel('Clear'));
+      await tester.pumpAndSettle();
+
+      expect(values, [null]);
+    });
+
     testWidgets('showing popover does not cause error', (tester) async {
       String? value;
 
@@ -199,6 +228,26 @@ void main() {
 
       expect(changedValue, 'A');
     });
+
+    testWidgets('onChange called when clearing via clear button', (tester) async {
+      final values = <String?>[];
+
+      await tester.pumpWidget(
+        TestScaffold.app(
+          child: FSelect<String>(
+            key: key,
+            clearable: true,
+            control: .managed(initial: 'A', onChange: values.add),
+            items: letters,
+          ),
+        ),
+      );
+
+      await tester.tap(find.bySemanticsLabel('Clear'));
+      await tester.pumpAndSettle();
+
+      expect(values, [null]);
+    });
   });
 
   group('form', () {

forui/test/src/widgets/time_field/input/input_time_field_test.dart

@@ -32,6 +32,31 @@ void main() {
 
       expect(changedValue, const FTime(0, 1));
     });
+
+    testWidgets('onChange called when clearing via clear button', (tester) async {
+      final values = <FTime?>[];
+
+      await tester.pumpWidget(
+        TestScaffold.app(
+          locale: const Locale('en', 'SG'),
+          child: FTimeField(
+            key: key,
+            clearable: true,
+            control: .managed(onChange: values.add),
+          ),
+        ),
+      );
+
+      await tester.enterText(find.byKey(key), '12:30 pm');
+      await tester.pumpAndSettle();
+
+      expect(values, [const FTime(12, 30)]);
+
+      await tester.tap(find.bySemanticsLabel('Clear'));
+      await tester.pumpAndSettle();
+
+      expect(values, [const FTime(12, 30), null]);
+    });
   });
 
   group('lifted', () {