WebhooksService.remove() silently no-ops instead of 404

[martinzhames]

Category: bug

Problem

src/webhooks/webhooks.service.ts remove(id, merchantId) (lines 44-46): const webhook = await this.webhooksRepo.findOne({ where: { id, merchantId } }); if (webhook) await this.webhooksRepo.remove(webhook); — if no matching webhook is found (wrong id, or the id belongs to another merchant), the method returns undefined without throwing anything, and the controller (src/webhooks/webhooks.controller.ts remove()) returns whatever that is with a 200-ish response.

Impact

Contradicts the controller's own @ApiNotFoundResponse({ description: 'Webhook not found' }) documentation — callers get a success-shaped response for a delete that didn't happen, e.g. when probing another merchant's webhook id, making it hard to distinguish "deleted" from "nothing happened".

Suggested fix

Throw NotFoundException('Webhook not found') when webhook is null/undefined, matching the documented contract.

[opeolarewaju5-glitch]

@opeolarewaju5-glitch has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, i can fix this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @opeolarewaju5-glitch to this issue.

[olufunsoolutayo]

@olufunsoolutayo has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would like to work on this issue. Please assign it to me. Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @olufunsoolutayo to this issue.

[Oluwasuyi-Oluwatimilehin-Daniel]

@Oluwasuyi-Oluwatimilehin-Daniel has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello @maintainer, I’d like to work on this issue. I have experience handling similar tasks and can start immediately. And I will deliver at the shortest possible time.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oluwasuyi-Oluwatimilehin-Daniel to this issue.

[MuhammadDG]

@MuhammadDG has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I’ve taken some time to understand the issue and its requirements, and I’m confident I can work on it effectively. I’d appreciate the opportunity to take it up.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @MuhammadDG to this issue.

[Demilade10]

@Demilade10 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi I can fix this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Demilade10 to this issue.