Validate external payload storage policy types

Author: durable-workflow-ops

src/durable_workflow/external_storage.py

@@ -50,14 +50,18 @@ def from_dict(cls, data: object) -> ExternalPayloadStoragePolicy:
         """Parse a server namespace or Cloud organization storage policy."""
         policy = _extract_policy(data)
         driver = _optional_string(policy.get("driver"), "external payload storage driver")
-        enabled = bool(policy.get("enabled", driver is not None))
+        enabled = _optional_bool(policy.get("enabled"), "enabled", default=driver is not None)
         threshold_bytes = _optional_positive_int(policy.get("threshold_bytes"), "threshold_bytes")
         config = _optional_mapping(policy.get("config"), "config")
         prefix = _optional_string(policy.get("prefix"), "prefix") or _optional_string(
             config.get("prefix"),
             "config.prefix",
         )
-        integrity_required = bool(policy.get("integrity_required", True))
+        integrity_required = _optional_bool(
+            policy.get("integrity_required"),
+            "integrity_required",
+            default=True,
+        )
 
         return cls(
             enabled=enabled,
@@ -520,10 +524,18 @@ def _optional_string(data: object, field_name: str) -> str | None:
     return data
 
 
+def _optional_bool(data: object, field_name: str, *, default: bool) -> bool:
+    if data is None:
+        return default
+    if not isinstance(data, bool):
+        raise ValueError(f"external payload storage policy {field_name} must be a boolean")
+    return data
+
+
 def _optional_positive_int(data: object, field_name: str) -> int | None:
     if data is None:
         return None
-    if not isinstance(data, int) or data < 1:
+    if type(data) is not int or data < 1:
         raise ValueError(f"external payload storage policy {field_name} must be a positive integer")
     return data
 

tests/test_external_storage.py

@@ -515,5 +515,23 @@ def test_external_storage_policy_validates_threshold_and_config_shape() -> None:
     with pytest.raises(ValueError, match="threshold_bytes"):
         ExternalPayloadStoragePolicy.from_dict({"driver": "local", "threshold_bytes": 0})
 
+    with pytest.raises(ValueError, match="threshold_bytes"):
+        ExternalPayloadStoragePolicy.from_dict({"driver": "local", "threshold_bytes": True})
+
     with pytest.raises(ValueError, match="config"):
         ExternalPayloadStoragePolicy.from_dict({"driver": "local", "config": "file:///tmp/payloads"})
+
+
+def test_external_storage_policy_validates_boolean_fields() -> None:
+    with pytest.raises(ValueError, match="enabled"):
+        ExternalPayloadStoragePolicy.from_dict({"driver": "local", "enabled": "false"})
+
+    with pytest.raises(ValueError, match="integrity_required"):
+        ExternalPayloadStoragePolicy.from_dict({"driver": "local", "integrity_required": 1})
+
+    policy = ExternalPayloadStoragePolicy.from_dict(
+        {"driver": "local", "enabled": False, "integrity_required": False}
+    )
+
+    assert policy.enabled is False
+    assert policy.integrity_required is False