Skip to content

Commit e58eecd

Browse files
authored
Merge pull request redhat-developer#33 from redhat-developer/fix-konflux-tekton-updates-skill
fix: skill should not hardcode 1- in the...
2 parents 48833ea + 36c32eb commit e58eecd

2 files changed

Lines changed: 20 additions & 0 deletions

File tree

skills/konflux-tekton-updates/SKILL.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,4 @@ Use live `MIGRATION.md` as source of truth. Common cases:
9191
- Leaving removed task params (`dev-package-managers`, `COMMIT_SHA` on `build-image-index`).
9292
- Adding `verify_*` guards that fail on the next Konflux bump.
9393
- Dropping `image-expires-after` from PLRs only because `build-image-index` no longer uses it.
94+
- Hardcoding `1-` in `generatePipelineRunsForPlugins.sh` Containerfile comments; use `${RHDH_XY_VERSION}` so `1.10.0` becomes `1-10`, not `1`.

skills/konflux-tekton-updates/references/plugin-catalog.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,22 @@ Add to the PipelineRun heredoc `spec.params` when `oci-plugin-build-pipeline` ga
3131
```
3232
3333
Do not embed full `pipelineSpec` in the generator.
34+
35+
## Version naming (x.y.z → x-y)
36+
37+
`generatePipelineRunsForPlugins.sh` derives `RHDH_XY_VERSION` from `-v x.y.z` (e.g. `1.10.0` → `1-10`). Use it everywhere; never hardcode `1-` in generated paths.
38+
39+
| Pattern | Example for 1.10.0 |
40+
|---------|-------------------|
41+
| PLR / Containerfile basename | `bcp-rbac-1-10-push.{yaml,Containerfile}` |
42+
| Konflux component / application | `bcp-rbac-1-10`, `rhdh-plugin-catalog-1-10` |
43+
| Target branch in CEL | `rhdh-1.10-rhel-9` (dots, not dashes) |
44+
| Containerfile builder comment | `.tekton/plugin-catalog-builder-1-10-push.yaml` |
45+
46+
After regenerate, grep for stale `-1-push` (without minor version):
47+
48+
```bash
49+
rg '-1-push' .tekton --glob '*.Containerfile'
50+
```
51+
52+
A hit like `plugin-catalog-builder-1-push.yaml` means the generator heredoc still hardcodes `1-` instead of `${RHDH_XY_VERSION}`.

0 commit comments

Comments
 (0)