fix: migrate Pester tests to v5 syntax for CI compatibility

- BeforeAll at script root (Pester 5 requirement)
- Should -Be instead of Should Be (legacy v3 syntax removed)
- Should -Not -Throw instead of Should Not Throw
- $PSScriptRoot instead of $MyInvocation.MyCommand.Path
- Cross-platform absolute path test (Windows vs Linux)
- validate.yml: explicit Pester 5 install + New-PesterConfiguration

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: dusan-maintains

.github/workflows/validate.yml

@@ -25,10 +25,20 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
+      - name: Install Pester 5
+        shell: pwsh
+        run: |
+          Install-Module -Name Pester -MinimumVersion 5.0 -Force -Scope CurrentUser -SkipPublisherCheck
+
       - name: Run Pester tests
         shell: pwsh
         run: |
-          $results = Invoke-Pester tests/ -PassThru
+          Import-Module Pester -MinimumVersion 5.0
+          $config = New-PesterConfiguration
+          $config.Run.Path = "tests/"
+          $config.Run.PassThru = $true
+          $config.Output.Verbosity = "Detailed"
+          $results = Invoke-Pester -Configuration $config
           if ($results.FailedCount -gt 0) { exit 1 }
 
   test-cli:

tests/common.Tests.ps1

@@ -1,21 +1,22 @@
-$here = Split-Path -Parent $MyInvocation.MyCommand.Path
-. (Join-Path (Join-Path (Join-Path $here "..") "scripts") "common.ps1")
+BeforeAll {
+  . (Join-Path $PSScriptRoot ".." "scripts" "common.ps1")
+}
 
 Describe "New-GitHubHeaders" {
 
   It "returns User-Agent header without token" {
     $env:GITHUB_TOKEN = ""
     $h = New-GitHubHeaders
-    $h["User-Agent"] | Should Be "dusan-maintains-oss-log"
-    $h.ContainsKey("Authorization") | Should Be $false
+    $h["User-Agent"] | Should -Be "dusan-maintains-oss-log"
+    $h.ContainsKey("Authorization") | Should -Be $false
   }
 
   It "includes Authorization when GITHUB_TOKEN is set" {
     $env:GITHUB_TOKEN = "test-token-123"
     try {
       $h = New-GitHubHeaders
-      $h["Authorization"] | Should Be "Bearer test-token-123"
-      $h["X-GitHub-Api-Version"] | Should Be "2022-11-28"
+      $h["Authorization"] | Should -Be "Bearer test-token-123"
+      $h["X-GitHub-Api-Version"] | Should -Be "2022-11-28"
     } finally {
       $env:GITHUB_TOKEN = ""
     }
@@ -26,21 +27,25 @@ Describe "Get-RepoRoot" {
 
   It "returns the parent of scripts directory" {
     $root = Get-RepoRoot
-    $root | Should Not BeNullOrEmpty
-    (Test-Path (Join-Path $root "scripts")) | Should Be $true
+    $root | Should -Not -BeNullOrEmpty
+    (Test-Path (Join-Path $root "scripts")) | Should -Be $true
   }
 }
 
 Describe "Resolve-RepoPath" {
 
   It "resolves a relative path to repo root" {
     $resolved = Resolve-RepoPath -Path "config/tracked-repositories.json"
-    $resolved | Should Match "tracked-repositories\.json$"
+    $resolved | Should -Match "tracked-repositories\.json$"
   }
 
   It "returns absolute paths unchanged" {
-    $abs = "C:\absolute\path.json"
-    (Resolve-RepoPath -Path $abs) | Should Be $abs
+    if ($IsWindows -or $env:OS -match "Windows") {
+      $abs = "C:\absolute\path.json"
+    } else {
+      $abs = "/absolute/path.json"
+    }
+    (Resolve-RepoPath -Path $abs) | Should -Be $abs
   }
 }
 
@@ -49,9 +54,9 @@ Describe "Ensure-Directory" {
   It "creates a directory if it does not exist" {
     $testDir = Join-Path ([System.IO.Path]::GetTempPath()) "oss-test-$(Get-Random)"
     try {
-      (Test-Path $testDir) | Should Be $false
+      (Test-Path $testDir) | Should -Be $false
       Ensure-Directory -Path $testDir
-      (Test-Path $testDir) | Should Be $true
+      (Test-Path $testDir) | Should -Be $true
     } finally {
       if (Test-Path $testDir) { Remove-Item $testDir -Recurse -Force }
     }
@@ -61,7 +66,7 @@ Describe "Ensure-Directory" {
     $testDir = Join-Path ([System.IO.Path]::GetTempPath()) "oss-test-$(Get-Random)"
     New-Item -ItemType Directory -Path $testDir | Out-Null
     try {
-      { Ensure-Directory -Path $testDir } | Should Not Throw
+      { Ensure-Directory -Path $testDir } | Should -Not -Throw
     } finally {
       Remove-Item $testDir -Recurse -Force
     }
@@ -72,18 +77,18 @@ Describe "Get-TrackedConfig" {
 
   It "parses the default config file" {
     $cfg = Get-TrackedConfig
-    $cfg.version | Should Be 1
-    $cfg.contributor | Should Be "dusan-maintains"
-    $cfg.repositories.Count | Should BeGreaterThan 4
+    $cfg.version | Should -Be 1
+    $cfg.contributor | Should -Be "dusan-maintains"
+    $cfg.repositories.Count | Should -BeGreaterThan 4
   }
 
   It "each repository has required fields" {
     $cfg = Get-TrackedConfig
     foreach ($repo in $cfg.repositories) {
-      $repo.owner | Should Not BeNullOrEmpty
-      $repo.repo | Should Not BeNullOrEmpty
-      $repo.tracked_pr_numbers | Should Not BeNullOrEmpty
-      $repo.review_sla_base_name | Should Not BeNullOrEmpty
+      $repo.owner | Should -Not -BeNullOrEmpty
+      $repo.repo | Should -Not -BeNullOrEmpty
+      $repo.tracked_pr_numbers | Should -Not -BeNullOrEmpty
+      $repo.review_sla_base_name | Should -Not -BeNullOrEmpty
     }
   }
 }
@@ -92,14 +97,14 @@ Describe "Convert-StringToUtcDateTime" {
 
   It "parses ISO 8601 strings" {
     $dt = Convert-StringToUtcDateTime -Value "2026-03-15T12:30:00Z"
-    $dt.Year | Should Be 2026
-    $dt.Month | Should Be 3
-    $dt.Day | Should Be 15
-    $dt.Hour | Should Be 12
-    $dt.Minute | Should Be 30
+    $dt.Year | Should -Be 2026
+    $dt.Month | Should -Be 3
+    $dt.Day | Should -Be 15
+    $dt.Hour | Should -Be 12
+    $dt.Minute | Should -Be 30
   }
 
   It "throws on invalid input" {
-    { Convert-StringToUtcDateTime -Value "not-a-date" } | Should Throw
+    { Convert-StringToUtcDateTime -Value "not-a-date" } | Should -Throw
   }
 }

tests/health-score.Tests.ps1

@@ -1,71 +1,72 @@
-$here = Split-Path -Parent $MyInvocation.MyCommand.Path
-. (Join-Path (Join-Path (Join-Path $here "..") "scripts") "common.ps1")
+BeforeAll {
+  . (Join-Path $PSScriptRoot ".." "scripts" "common.ps1")
 
-function Get-LogScore {
-  param([double]$Value, [double]$Scale = 1000)
-  if ($Value -le 0) { return 0 }
-  $raw = [Math]::Log10($Value + 1) / [Math]::Log10($Scale + 1) * 10
-  return [Math]::Min([Math]::Round($raw, 2), 10)
-}
+  function Get-LogScore {
+    param([double]$Value, [double]$Scale = 1000)
+    if ($Value -le 0) { return 0 }
+    $raw = [Math]::Log10($Value + 1) / [Math]::Log10($Scale + 1) * 10
+    return [Math]::Min([Math]::Round($raw, 2), 10)
+  }
 
-function Get-DecayScore {
-  param([double]$DaysSinceEvent, [double]$HalfLifeDays = 180)
-  if ($DaysSinceEvent -le 0) { return 10 }
-  $score = 10 * [Math]::Exp(-0.693 * $DaysSinceEvent / $HalfLifeDays)
-  return [Math]::Round([Math]::Max($score, 0), 2)
+  function Get-DecayScore {
+    param([double]$DaysSinceEvent, [double]$HalfLifeDays = 180)
+    if ($DaysSinceEvent -le 0) { return 10 }
+    $score = 10 * [Math]::Exp(-0.693 * $DaysSinceEvent / $HalfLifeDays)
+    return [Math]::Round([Math]::Max($score, 0), 2)
+  }
 }
 
 Describe "Get-LogScore" {
 
   It "returns 0 for zero input" {
-    (Get-LogScore -Value 0) | Should Be 0
+    (Get-LogScore -Value 0) | Should -Be 0
   }
 
   It "returns 0 for negative input" {
-    (Get-LogScore -Value -5) | Should Be 0
+    (Get-LogScore -Value -5) | Should -Be 0
   }
 
   It "returns score between 0 and 10 for positive values" {
     $score = Get-LogScore -Value 500 -Scale 1000
-    $score | Should BeGreaterThan 0
-    $score | Should Not BeGreaterThan 10
+    $score | Should -BeGreaterThan 0
+    $score | Should -Not -BeGreaterThan 10
   }
 
   It "scales logarithmically - 1M scores higher than 1k" {
     $low = Get-LogScore -Value 1000 -Scale 1000000
     $high = Get-LogScore -Value 1000000 -Scale 1000000
-    $high | Should BeGreaterThan $low
+    $high | Should -BeGreaterThan $low
   }
 
   It "caps at 10" {
     $score = Get-LogScore -Value 999999999 -Scale 1000
-    $score | Should Be 10
+    $score | Should -Be 10
   }
 }
 
 Describe "Get-DecayScore" {
 
   It "returns 10 for 0 days" {
-    (Get-DecayScore -DaysSinceEvent 0) | Should Be 10
+    (Get-DecayScore -DaysSinceEvent 0) | Should -Be 10
   }
 
   It "returns approximately 5 at half-life" {
     $score = Get-DecayScore -DaysSinceEvent 180 -HalfLifeDays 180
-    $score | Should BeGreaterThan 4
-    $score | Should BeLessThan 6
+    $score | Should -BeGreaterThan 4
+    $score | Should -BeLessThan 6
   }
 
   It "scores decrease over time" {
     $fresh = Get-DecayScore -DaysSinceEvent 30
     $old = Get-DecayScore -DaysSinceEvent 365
     $ancient = Get-DecayScore -DaysSinceEvent 730
-    $fresh | Should BeGreaterThan $old
-    $old | Should BeGreaterThan $ancient
+    $fresh | Should -BeGreaterThan $old
+    $old | Should -BeGreaterThan $ancient
   }
 
   It "never goes below 0" {
     $score = Get-DecayScore -DaysSinceEvent 99999
-    $score | Should Not BeLessThan 0
+    $score | Should -BeGreaterOrEqual 0
   }
 }
 
@@ -75,11 +76,11 @@ Describe "Health Score JSON Schema" {
     $jsonPath = Join-Path (Join-Path (Get-RepoRoot) "evidence") "health-scores.json"
     if (Test-Path $jsonPath) {
       $data = Get-Content $jsonPath -Raw | ConvertFrom-Json
-      $data.generated_at_utc | Should Not BeNullOrEmpty
-      $data.summary.total_projects | Should BeGreaterThan 0
+      $data.generated_at_utc | Should -Not -BeNullOrEmpty
+      $data.summary.total_projects | Should -BeGreaterThan 0
       foreach ($s in $data.scores) {
-        $s.health_score | Should Not BeLessThan 0
-        $s.health_score | Should Not BeGreaterThan 100
+        $s.health_score | Should -BeGreaterOrEqual 0
+        $s.health_score | Should -BeLessOrEqual 100
       }
     }
   }