Skip to content

Commit 46a5a2a

Browse files
authored
Merge pull request #24 from duylongpro99/development
wip
2 parents 00f1ce4 + 15d4c57 commit 46a5a2a

File tree

2 files changed

+5
-18
lines changed

2 files changed

+5
-18
lines changed

.github/workflows/build-reusable.yml

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,14 @@ jobs:
5454
# Run regular install
5555
pnpm install
5656
fi
57-
58-
- name: Set up environment variables
59-
run: |
60-
# Create .env file
61-
touch .env
62-
63-
# Add Convex specific variables
64-
echo "NEXT_PUBLIC_CONVEX_URL=${{ secrets.NEXT_PUBLIC_CONVEX_URL }}" >> .env
65-
echo "CONVEX_DEPLOYMENT=${{ secrets.CONVEX_DEPLOYMENT }}" >> .env
66-
67-
# Add other public and private environment variables
68-
echo "CLERK_SECRET_KEY=${{ secrets.CLERK_SECRET_KEY }}" >> .env
69-
echo "NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }}" >> .env
70-
71-
# Liveblocks secret key:
72-
echo "LIVE_BLOCK_SECRET_API_KEY=${{secrets.LIVE_BLOCK_SECRET_API_KEY}}" >> .env
73-
7457
- name: Build
7558
id: build_step # Added this ID which is referenced in the outputs
7659
env:
7760
NEXT_PUBLIC_CONVEX_URL: ${{ secrets.NEXT_PUBLIC_CONVEX_URL }}
61+
CONVEX_DEPLOYMENT: ${{ secrets.CONVEX_DEPLOYMENT }}
62+
CLERK_SECRET_KEY: ${{ secrets.CLERK_SECRET_KEY }}
63+
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }}
64+
# Liveblocks secret key:
7865
LIVE_BLOCK_SECRET_API_KEY: ${{ secrets.LIVE_BLOCK_SECRET_API_KEY }}
7966
run: |
8067
pnpm build

src/app/document/[documentId]/room.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function Room({ children }: { children: ReactNode }) {
3636
});
3737
}
3838
},
39-
[]
39+
[toast]
4040
);
4141

4242
useEffect(() => {

0 commit comments

Comments
 (0)