Add method to find a single directive in scope and update audit logic

Author: dvershinin

gixy/directives/directive.py

@@ -37,13 +37,15 @@ def set_parent(self, parent):
 
     @property
     def parents(self):
+        """Get all parent blocks"""
         parent = self.parent
         while parent:
             yield parent
             parent = parent.parent
 
     @property
     def variables(self):
+        """Get all variables provided by this directive"""
         raise NotImplementedError()
 
     def find_directives_in_scope(self, name):
@@ -54,11 +56,21 @@ def find_directives_in_scope(self, name):
                 yield directive
         return None
 
+    def find_single_directive_in_scope(self, name):
+        """Find a single directive in the current scope"""
+        for parent in self.parents:
+            directive = parent.some(name, flat=False)
+            if directive:
+                return directive
+        return None
+
     def __str__(self):
-        return "{name} {args};".format(name=self.name, args=" ".join(self.args))
+        return f"{self.name} {' '.join(self.args)};"
 
 
 class AddHeaderDirective(Directive):
+    """The add_header directive is used to add a header to the response"""
+
     nginx_name = "add_header"
 
     def __init__(self, name, args):

gixy/plugins/try_files_is_evil_too.py

@@ -1,3 +1,5 @@
+"""Module for try_files_is_evil_too plugin."""
+
 import gixy
 from gixy.plugins.plugin import Plugin
 
@@ -18,8 +20,8 @@ class try_files_is_evil_too(Plugin):
 
     def audit(self, directive):
         # search for open_file_cache ...; on the same or higher level
-        open_file_cache = list(directive.find_directives_in_scope("open_file_cache"))
-        if not open_file_cache or open_file_cache[0].args[0] == "off":
+        open_file_cache = directive.find_single_directive_in_scope("open_file_cache")
+        if not open_file_cache or open_file_cache.args[0] == "off":
             self.add_issue(
                 severity=gixy.severity.MEDIUM,
                 directive=[directive],