Skip to content

Commit 1b31d84

Browse files
Michael McNeesclaude
authored andcommitted
fix: address CodeRabbit review feedback on PR #141
- Pin alpine:3.21 to correct digest (1f390db) in Dockerfile.goreleaser - Pin go-licenses to @v2.0.1 instead of @latest in release-engine.yml - Update stale comment in server.go: /readyz no longer uses worker/reaper liveness checkers; explain the intentional design decision Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 17dc0f2 commit 1b31d84

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/release-engine.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
4747
- name: Generate NOTICE
4848
run: |
49-
go install github.com/google/go-licenses@latest
49+
go install github.com/google/go-licenses@v2.0.1
5050
go-licenses report ./... > NOTICE
5151
working-directory: packages/engine
5252

packages/engine/Dockerfile.goreleaser

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM alpine:3.21@sha256:48b0309ca019d89d40f670aa1bc06e426dc0931948452e8491e3d65087abc07d
1+
FROM alpine:3.21@sha256:1f390db9d9746cc317e16a98a8be2854c599abcbf04d45b6320b040e72034e33
22

33
RUN apk add --no-cache ca-certificates tzdata \
44
&& addgroup -S mantle \

packages/engine/internal/server/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,8 @@ func (s *Server) Start(ctx context.Context) error {
238238
go s.pollQueueDepth(ctx, cfg.Engine.ReaperInterval)
239239
}
240240

241-
// Health endpoints (registered after engine components so checkers are populated).
241+
// Health endpoints. /readyz checks DB connectivity only; worker/reaper
242+
// liveness is no longer gated here to avoid flapping between poll cycles.
242243
mux.Handle("/healthz", health.HealthzHandler())
243244
mux.Handle("/readyz", health.ReadyzHandler(s.DB))
244245

0 commit comments

Comments
 (0)