test(budget): add team hard block, provider usage error, and upper-bound clamp tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: michaelmcnees

internal/budget/budget_test.go

@@ -150,6 +150,55 @@ func TestChecker_Check_FailOpenOnGetTeamBudgetError(t *testing.T) {
 	assert.False(t, result.Warning)
 }
 
+func TestChecker_Check_FailOpenOnGetProviderUsageError(t *testing.T) {
+	checker := &budget.Checker{
+		ResetMode: "calendar",
+		ResetDay:  1,
+		GetTotalUsage: func(ctx context.Context, period time.Time) (int64, error) {
+			return 0, nil
+		},
+		GetProviderUsage: func(ctx context.Context, teamID, provider string, period time.Time) (int64, error) {
+			return 0, fmt.Errorf("provider usage query failed")
+		},
+		GetTeamBudget: func(ctx context.Context, teamID, provider string) (*budget.TeamBudget, error) {
+			return &budget.TeamBudget{MonthlyTokenLimit: 5000, Enforcement: "hard"}, nil
+		},
+	}
+
+	result := checker.Check(context.Background(), budget.CheckInput{
+		TeamID:   "team-1",
+		Provider: "openai",
+	})
+
+	assert.False(t, result.Blocked)
+	assert.False(t, result.Warning)
+}
+
+func TestChecker_Check_TeamHardBlock(t *testing.T) {
+	checker := &budget.Checker{
+		ResetMode: "calendar",
+		ResetDay:  1,
+		GetTotalUsage: func(ctx context.Context, period time.Time) (int64, error) {
+			return 0, nil
+		},
+		GetProviderUsage: func(ctx context.Context, teamID, provider string, period time.Time) (int64, error) {
+			return 5001, nil
+		},
+		GetTeamBudget: func(ctx context.Context, teamID, provider string) (*budget.TeamBudget, error) {
+			return &budget.TeamBudget{MonthlyTokenLimit: 5000, Enforcement: "hard"}, nil
+		},
+	}
+
+	result := checker.Check(context.Background(), budget.CheckInput{
+		TeamID:   "team-1",
+		Provider: "openai",
+	})
+
+	assert.True(t, result.Blocked)
+	assert.Equal(t, "team", result.BlockedBy)
+	assert.Contains(t, result.Message, "team budget exceeded")
+}
+
 func TestChecker_CheckExecutionBudget(t *testing.T) {
 	result := budget.CheckExecutionBudget(50000, 50001)
 	assert.True(t, result.Blocked)

internal/config/config_test.go

@@ -226,7 +226,7 @@ func TestLoad_BudgetResetDay_RollingInvalid(t *testing.T) {
 }
 
 func TestLoad_BudgetResetDay_CalendarClamps(t *testing.T) {
-	// Invalid ResetDay with calendar mode should silently clamp to 1
+	// Invalid ResetDay with calendar mode should silently clamp to 1 (lower bound)
 	t.Setenv("MANTLE_ENGINE_BUDGET_RESET_MODE", "calendar")
 	t.Setenv("MANTLE_ENGINE_BUDGET_RESET_DAY", "0")
 
@@ -235,3 +235,15 @@ func TestLoad_BudgetResetDay_CalendarClamps(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, 1, cfg.Engine.Budget.ResetDay)
 }
+
+func TestLoad_BudgetResetDay_CalendarClampsUpperBound(t *testing.T) {
+	// ResetDay >28 with calendar mode should silently clamp to 1
+	// (calendar mode ignores reset_day entirely, so any invalid value is safe to clamp)
+	t.Setenv("MANTLE_ENGINE_BUDGET_RESET_MODE", "calendar")
+	t.Setenv("MANTLE_ENGINE_BUDGET_RESET_DAY", "100")
+
+	cmd := newTestCommand()
+	cfg, err := Load(cmd)
+	require.NoError(t, err)
+	assert.Equal(t, 1, cfg.Engine.Budget.ResetDay)
+}