Commit 5089655
* fix: improve mobile navigation and layouts on docs site
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat: replace mobile top nav with bottom navigation bar for better reachability
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* docs: add practical CEL expression reference with examples (closes #1)
Replace the thin CEL overview with comprehensive documentation covering
available variables, common expression patterns, template vs bare syntax,
type safety, bracket notation, and limitations. Update links in
data-passing and workflow-reference docs to point to cel.dev and the
new expressions guide instead of the go-cel GitHub repo.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat(docs): add search with Pagefind and Cmd+K shortcut (closes #5)
- Pagefind indexes all 28 doc pages at build time
- Search modal with Cmd+K / Ctrl+K keyboard shortcut
- Lazy-loads Pagefind JS on first search (no upfront cost)
- 200ms debounced input, up to 8 results with title + excerpt
- Search trigger in desktop nav (docs pages) and sidebar top
- Landing page excluded from index (data-pagefind-ignore)
- Styled with Terminal Green design tokens
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: address all 9 Copilot review comments on PR #6
Search component:
- Split into DocsSearch (trigger only) + SearchModal (single shared modal)
- SearchModal rendered once in Base.astro, no duplicate IDs
- Global Cmd+K handler registered once with guard flag
- Excerpt sanitized via DOMParser (only <mark> tags allowed)
- Dialog a11y: role="dialog", aria-modal="true", aria-label
Navigation:
- isDocs derived from Astro.url.pathname.startsWith('/docs')
- Nav/Sidebar overlay: use onclick assignment, no cloneNode (fixes detached ref)
Content:
- data-pagefind-ignore wraps entire landing page (Nav + Footer excluded too)
- Removed unused .table-wrapper CSS, applied scroll directly to .prose table
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: address 5 Copilot comments on PR #6
1. CEL link: separate external cel.dev link from internal expressions guide
2. status_code → status in server-guide (matches http.go output)
3. sanitizeExcerpt: recursive DOM walk preserves nested <mark> tags
4. Search race condition: requestId counter discards stale responses
5. Bottom padding: moved to global CSS @media (max-width: 1023px) body
so all pages (including 404) clear the mobile bottom nav
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: address reviewer comments — input type, deprecated CSS
- expressions.md: type: integer → type: number (matches valid input types)
- global.css: word-break: break-word → overflow-wrap: anywhere (deprecated)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: search modal focus trap, restore focus, invalidate on close
- Focus trap: Tab cycles within modal when open (first/last wrapping)
- Restore focus: previously focused trigger gets focus back on close
- Invalidate requests: searchRequestId incremented on open AND close,
preventing stale responses from populating after modal reset
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Update site/src/components/DocsSidebar.astro
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: address remaining review comments on PR #6
Verified each finding against current code — 4 needed fixes, 4 already done:
Fixed:
1. DocsSearch: cross-platform kbd (⌘K on Mac, Ctrl+K on Windows/Linux)
2. DocsSidebar: GitHub link target="_blank" rel="noopener"
3. Nav: aria-label on bottom nav, aria-controls + aria-expanded on menu
button, synced with toggle handler
4. server-guide: bracket notation for steps['check-api'] on line 74
Already fixed (verified):
- SearchModal focus trap (previousFocus, Tab cycling) ✓
- SearchModal requestId invalidation on open/close ✓
- expressions.md type: number (not integer) ✓
- CSS overflow-wrap: anywhere (not word-break: break-word) ✓
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: sync initial aria-expanded/aria-hidden state in initNav
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent 613b506 commit 5089655
10 files changed
Lines changed: 536 additions & 62 deletions
File tree
- site
- src
- components
- content/docs
- concepts
- getting-started
- server-guide
- workflow-reference
- layouts
- pages
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
0 commit comments