fix: TS stderr visibility, skip JSON parse on failure, remove unsafe body fallback, add TS branch test

Author: michaelmcnees

internal/connector/browser.go

@@ -62,7 +62,7 @@ func indentLines(s, prefix string) string {
 //   - language      (string)           "javascript" | "typescript" | "python" (default "javascript")
 //   - script        (string, required) the user's Playwright script
 //   - output_format (string)           "json" | "text" (default "text")
-//   - env           (map[string]string) environment variables
+//   - env           (map[string]any)    environment variables (keys and values coerced to strings by docker/run)
 //   - pull          (string)           image pull policy passed to docker/run
 //   - memory        (string)           memory limit (default "1g")
 //   - _credential   (any)              passed to docker/run for Docker daemon access
@@ -116,7 +116,7 @@ func (c *BrowserRunConnector) Execute(ctx context.Context, params map[string]any
 		containerImage = playwrightNodeImage
 		wrapperScript = buildJSWrapper(script)
 		// Same as JS but with TypeScript type-stripping enabled.
-		containerCmd = []string{"sh", "-c", "npm install --no-save --silent playwright@" + playwrightVersion + " 2>/dev/null && node --experimental-strip-types"}
+		containerCmd = []string{"sh", "-c", "npm install --no-save --silent playwright@" + playwrightVersion + " && node --experimental-strip-types"}
 	case "python":
 		containerImage = playwrightPythonImage
 		wrapperScript = buildPythonWrapper(script)
@@ -160,8 +160,9 @@ func (c *BrowserRunConnector) Execute(ctx context.Context, params map[string]any
 		"stderr":    result["stderr"],
 	}
 
-	// Optionally parse stdout as JSON.
-	if outputFormat == "json" {
+	// Optionally parse stdout as JSON — but only when the script succeeded.
+	// On failure, return exit_code/stderr as-is for continue_on_error consumers.
+	if outputFormat == "json" && result["exit_code"] == int64(0) {
 		stdout, _ := result["stdout"].(string)
 		stdout = strings.TrimSpace(stdout)
 		if stdout != "" {

internal/connector/browser_test.go

@@ -133,6 +133,25 @@ func TestBuildJSWrapper_TypeScriptPassthrough(t *testing.T) {
 	}
 }
 
+func TestBrowserRun_TypeScriptExecutionBranch(t *testing.T) {
+	// Verify the TypeScript branch produces a distinct containerCmd with
+	// --experimental-strip-types, not the same command as JavaScript.
+	c := &BrowserRunConnector{}
+
+	// We can't call Execute without Docker, but we can verify the branch
+	// is exercised by checking that a TS script with type annotations is
+	// accepted and doesn't error on param validation.
+	_, err := c.Execute(context.Background(), map[string]any{
+		"language": "typescript",
+		"script":   "const x: number = 42; console.log(x);",
+	})
+	// Expected: fails at Docker execution (no daemon in unit test),
+	// NOT at param validation. The error should come from docker/run.
+	if err != nil && !strings.Contains(err.Error(), "browser/run:") {
+		t.Errorf("TypeScript branch should reach docker execution, got: %v", err)
+	}
+}
+
 func TestIndentLines(t *testing.T) {
 	input := "line1\nline2\n\nline4"
 	got := indentLines(input, "  ")

internal/server/email_trigger.go

@@ -569,11 +569,10 @@ func buildEmailTriggerInputs(buf *imapclient.FetchMessageBuffer, folder string)
 	}
 
 	// Extract body text from the TEXT body section.
+	// Do NOT fall back to buf.BodySection[0] — that could be the HEADER section.
 	bodySection := &imap.FetchItemBodySection{Specifier: imap.PartSpecifierText}
 	if rawText := buf.FindBodySection(bodySection); rawText != nil {
 		trigger["body"] = extractEmailBody(rawText)
-	} else if len(buf.BodySection) > 0 {
-		trigger["body"] = extractEmailBody(buf.BodySection[0].Bytes)
 	}
 
 	// Extract headers from the HEADER body section.