fix(connector): address PR #145 review feedback

- pagerduty/resolve: make from_email required (PagerDuty rejects PUT /incidents
  without a From header when using REST API keys); accepted from credential or
  as an explicit param
- twilio/call: error when both url and twiml are supplied (mutually exclusive)
- asana/create_task: use toStringSlice for projects so []string and []any are
  both accepted without a silent nil fallback

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

packages/engine/internal/connector/asana.go

@@ -38,7 +38,7 @@ func (c *AsanaCreateTaskConnector) Execute(ctx context.Context, params map[strin
 	}
 
 	workspace, _ := params["workspace"].(string)
-	projects, _ := params["projects"].([]any)
+	projects := toStringSlice(params["projects"])
 	if workspace == "" && len(projects) == 0 {
 		return nil, fmt.Errorf("asana/create_task: workspace or projects is required")
 	}

packages/engine/internal/connector/asana_test.go

@@ -95,6 +95,7 @@ func TestAsanaCreateTaskConnector_WithProjects(t *testing.T) {
 		var body map[string]any
 		json.NewDecoder(r.Body).Decode(&body)
 		data := body["data"].(map[string]any)
+		// JSON round-trip produces []any from []string in the serialized body.
 		projects, _ := data["projects"].([]any)
 		if len(projects) != 1 || projects[0] != "PROJ123" {
 			t.Errorf("unexpected projects: %v", projects)
@@ -117,6 +118,33 @@ func TestAsanaCreateTaskConnector_WithProjects(t *testing.T) {
 	}
 }
 
+func TestAsanaCreateTaskConnector_ProjectsAsStringSlice(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		var body map[string]any
+		json.NewDecoder(r.Body).Decode(&body)
+		data := body["data"].(map[string]any)
+		projects, _ := data["projects"].([]any)
+		if len(projects) != 1 || projects[0] != "PROJ456" {
+			t.Errorf("unexpected projects: %v", projects)
+		}
+		w.WriteHeader(http.StatusCreated)
+		json.NewEncoder(w).Encode(map[string]any{
+			"data": map[string]any{"gid": "1", "name": "t", "permalink_url": ""},
+		})
+	}))
+	defer srv.Close()
+
+	c := &AsanaCreateTaskConnector{baseURL: srv.URL}
+	_, err := c.Execute(t.Context(), map[string]any{
+		"_credential": map[string]string{"token": "asana-token"},
+		"name":        "t",
+		"projects":    []string{"PROJ456"}, // native []string, not []any
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+}
+
 func TestAsanaCreateTaskConnector_MissingName(t *testing.T) {
 	c := &AsanaCreateTaskConnector{baseURL: "http://unused"}
 	_, err := c.Execute(t.Context(), map[string]any{

packages/engine/internal/connector/pagerduty.go

@@ -139,6 +139,15 @@ func (c *PagerDutyResolveConnector) Execute(ctx context.Context, params map[stri
 		return nil, fmt.Errorf("pagerduty/resolve: incident_id is required")
 	}
 
+	// from_email is required for REST API key auth: PagerDuty rejects incident
+	// updates without a From header when using non-user-context credentials.
+	if fromEmail == "" {
+		fromEmail, _ = params["from_email"].(string)
+	}
+	if fromEmail == "" {
+		return nil, fmt.Errorf("pagerduty/resolve: from_email is required (set in credential or as param)")
+	}
+
 	body := map[string]any{
 		"incident": map[string]any{
 			"type":   "incident",
@@ -158,11 +167,7 @@ func (c *PagerDutyResolveConnector) Execute(ctx context.Context, params map[stri
 	req.Header.Set("Authorization", "Token token="+token)
 	req.Header.Set("Content-Type", "application/json")
 	req.Header.Set("Accept", "application/vnd.pagerduty+json;version=2")
-	if fromEmail != "" {
-		req.Header.Set("From", fromEmail)
-	} else if fe, ok := params["from_email"].(string); ok && fe != "" {
-		req.Header.Set("From", fe)
-	}
+	req.Header.Set("From", fromEmail)
 
 	resp, err := httpClient(c.Client).Do(req)
 	if err != nil {

packages/engine/internal/connector/pagerduty_test.go

@@ -181,6 +181,9 @@ func TestPagerDutyResolveConnector_ResolvesIncident(t *testing.T) {
 		if r.Method != "PUT" || r.URL.Path != "/incidents/Q2AVLPZB5RX" {
 			t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
 		}
+		if r.Header.Get("From") != "oncall@example.com" {
+			t.Errorf("expected From header, got %s", r.Header.Get("From"))
+		}
 		var body map[string]any
 		json.NewDecoder(r.Body).Decode(&body)
 		inc := body["incident"].(map[string]any)
@@ -199,7 +202,7 @@ func TestPagerDutyResolveConnector_ResolvesIncident(t *testing.T) {
 
 	c := &PagerDutyResolveConnector{baseURL: srv.URL}
 	out, err := c.Execute(t.Context(), map[string]any{
-		"_credential": map[string]string{"token": "u+abc"},
+		"_credential": map[string]string{"token": "u+abc", "from_email": "oncall@example.com"},
 		"incident_id": "Q2AVLPZB5RX",
 	})
 	if err != nil {
@@ -210,6 +213,40 @@ func TestPagerDutyResolveConnector_ResolvesIncident(t *testing.T) {
 	}
 }
 
+func TestPagerDutyResolveConnector_FromEmailInParam(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		if r.Header.Get("From") != "param@example.com" {
+			t.Errorf("expected From=param@example.com, got %s", r.Header.Get("From"))
+		}
+		w.Header().Set("Content-Type", "application/json")
+		json.NewEncoder(w).Encode(map[string]any{
+			"incident": map[string]any{"id": "Q1", "status": "resolved"},
+		})
+	}))
+	defer srv.Close()
+
+	c := &PagerDutyResolveConnector{baseURL: srv.URL}
+	_, err := c.Execute(t.Context(), map[string]any{
+		"_credential": map[string]string{"token": "u+abc"},
+		"incident_id": "Q1",
+		"from_email":  "param@example.com",
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+}
+
+func TestPagerDutyResolveConnector_MissingFromEmail(t *testing.T) {
+	c := &PagerDutyResolveConnector{baseURL: "http://unused"}
+	_, err := c.Execute(t.Context(), map[string]any{
+		"_credential": map[string]string{"token": "u+abc"},
+		"incident_id": "Q1",
+	})
+	if err == nil {
+		t.Fatal("expected error when from_email is missing")
+	}
+}
+
 func TestPagerDutyResolveConnector_MissingIncidentID(t *testing.T) {
 	c := &PagerDutyResolveConnector{baseURL: "http://unused"}
 	_, err := c.Execute(t.Context(), map[string]any{

packages/engine/internal/connector/twilio.go

@@ -126,6 +126,9 @@ func (c *TwilioCallConnector) Execute(ctx context.Context, params map[string]any
 	if callURL == "" && twiml == "" {
 		return nil, fmt.Errorf("twilio/call: url or twiml is required")
 	}
+	if callURL != "" && twiml != "" {
+		return nil, fmt.Errorf("twilio/call: url and twiml are mutually exclusive; provide only one")
+	}
 
 	form := url.Values{}
 	form.Set("To", to)

packages/engine/internal/connector/twilio_test.go

@@ -207,6 +207,20 @@ func TestTwilioCallConnector_MissingURLAndTwiml(t *testing.T) {
 	}
 }
 
+func TestTwilioCallConnector_BothURLAndTwiml(t *testing.T) {
+	c := &TwilioCallConnector{baseURL: "http://unused"}
+	_, err := c.Execute(t.Context(), map[string]any{
+		"_credential": map[string]string{"account_sid": "ACtest123", "auth_token": "secret"},
+		"to":          "+15551234567",
+		"from":        "+15559876543",
+		"url":         "https://example.com/twiml",
+		"twiml":       "<Response><Say>Hi</Say></Response>",
+	})
+	if err == nil {
+		t.Fatal("expected error when both url and twiml are set")
+	}
+}
+
 func TestTwilioCallConnector_MissingTo(t *testing.T) {
 	c := &TwilioCallConnector{baseURL: "http://unused"}
 	_, err := c.Execute(t.Context(), map[string]any{