fix: make integration tests CI-resilient — install playwright inline, retry IMAP connections

- browser/run: change JS/TS and Python container commands to install the
  playwright npm/pip package inline before executing the script. The
  Microsoft Playwright Docker images ship browsers but not the Node API
  package, causing MODULE_NOT_FOUND errors in CI.

- TestIMAPDial: add a 5-attempt retry loop (2s sleep) around imapDial.
  GreenMail may not accept logins immediately after the "Starting
  GreenMail" log line appears in CI.

- fetchFirstUID: replace the single-shot call with a 5-attempt retry
  loop (2s sleep) so that SMTP-to-IMAP visibility delay in CI doesn't
  cause TestEmailDelete_DeletesMessage and TestEmailMove_MovesMessage
  to fail with "no messages found".

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: michaelmcnees

internal/connector/browser.go

@@ -107,18 +107,21 @@ func (c *BrowserRunConnector) Execute(ctx context.Context, params map[string]any
 	case "javascript":
 		containerImage = playwrightNodeImage
 		wrapperScript = buildJSWrapper(script)
-		// Pass the wrapper via stdin; `node` reads from stdin when no file argument is given.
-		containerCmd = []string{"node"}
+		// The Playwright Docker image ships browsers but not the npm package.
+		// Install it silently before running so the script can require('playwright').
+		// `node` with no file argument reads the script from stdin.
+		containerCmd = []string{"sh", "-c", "cd /tmp && npm init -y --silent 2>/dev/null && npm install --silent playwright 2>/dev/null && node"}
 	case "typescript":
 		containerImage = playwrightNodeImage
 		wrapperScript = buildJSWrapper(script)
-		// Use --experimental-strip-types so Node can execute TypeScript directly.
-		containerCmd = []string{"node", "--experimental-strip-types"}
+		// Same npm-install preamble; use --experimental-strip-types for TS syntax.
+		containerCmd = []string{"sh", "-c", "cd /tmp && npm init -y --silent 2>/dev/null && npm install --silent playwright 2>/dev/null && node --experimental-strip-types"}
 	case "python":
 		containerImage = playwrightPythonImage
 		wrapperScript = buildPythonWrapper(script)
-		// Pass the wrapper via stdin; `python3 -` reads from stdin.
-		containerCmd = []string{"python3", "-"}
+		// Install the playwright Python package if not already present, then run
+		// the script via stdin (`python3 -`).
+		containerCmd = []string{"sh", "-c", "pip install --quiet playwright 2>/dev/null && python3 -"}
 	}
 
 	// --- build docker/run params ---

internal/connector/email_move_test.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net/smtp"
 	"testing"
+	"time"
 )
 
 // TestEmailMoveParamValidation verifies that required parameters are enforced.
@@ -150,31 +151,45 @@ func createTargetFolder(t *testing.T, host, imapPort, username, password, folder
 
 // fetchFirstUID retrieves the first UID from the given IMAP folder using the
 // EmailReceiveConnector, to avoid duplicating IMAP client logic in tests.
+// It retries up to 5 times with a 2-second pause to accommodate the brief
+// delay between SMTP delivery and IMAP visibility in CI.
 func fetchFirstUID(t *testing.T, host, imapPort, username, password, folder string) uint32 {
 	t.Helper()
 	recv := &EmailReceiveConnector{}
-	result, err := recv.Execute(context.Background(), map[string]any{
-		"folder": folder,
-		"filter": "all",
-		"limit":  1,
-		"_credential": map[string]string{
-			"host":     host,
-			"port":     imapPort,
-			"username": username,
-			"password": password,
-			"use_tls":  "false",
-		},
-	})
-	if err != nil {
-		t.Fatalf("fetchFirstUID: receive error: %v", err)
-	}
-	msgs, ok := result["messages"].([]map[string]any)
-	if !ok || len(msgs) == 0 {
-		t.Fatal("fetchFirstUID: no messages found")
+	cred := map[string]string{
+		"host":     host,
+		"port":     imapPort,
+		"username": username,
+		"password": password,
+		"use_tls":  "false",
 	}
-	uid, _ := msgs[0]["uid"].(uint32)
-	if uid == 0 {
-		t.Fatal("fetchFirstUID: uid is zero")
+
+	for attempt := 0; attempt < 5; attempt++ {
+		if attempt > 0 {
+			time.Sleep(2 * time.Second)
+		}
+		result, err := recv.Execute(context.Background(), map[string]any{
+			"folder":      folder,
+			"filter":      "all",
+			"limit":       1,
+			"_credential": cred,
+		})
+		if err != nil {
+			t.Logf("fetchFirstUID attempt %d/5: receive error: %v", attempt+1, err)
+			continue
+		}
+		msgs, ok := result["messages"].([]map[string]any)
+		if !ok || len(msgs) == 0 {
+			t.Logf("fetchFirstUID attempt %d/5: no messages yet", attempt+1)
+			continue
+		}
+		uid, _ := msgs[0]["uid"].(uint32)
+		if uid == 0 {
+			t.Logf("fetchFirstUID attempt %d/5: uid is zero", attempt+1)
+			continue
+		}
+		return uid
 	}
-	return uid
+	t.Fatal("fetchFirstUID: no messages found after retries")
+	return 0
 }

internal/connector/imap_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/emersion/go-imap/v2/imapclient"
 	"github.com/testcontainers/testcontainers-go"
 	"github.com/testcontainers/testcontainers-go/wait"
 )
@@ -72,9 +73,22 @@ func TestIMAPDial(t *testing.T) {
 		UseTLS:   false,
 	}
 
-	client, err := imapDial(cfg)
+	// GreenMail may not accept logins immediately after the startup log line.
+	// Retry with a short backoff to handle this CI timing window.
+	var client *imapclient.Client
+	var err error
+	for attempt := 0; attempt < 5; attempt++ {
+		if attempt > 0 {
+			time.Sleep(2 * time.Second)
+		}
+		client, err = imapDial(cfg)
+		if err == nil {
+			break
+		}
+		t.Logf("imapDial attempt %d/5 failed: %v", attempt+1, err)
+	}
 	if err != nil {
-		t.Fatalf("imapDial() error: %v", err)
+		t.Fatalf("imapDial() error after retries: %v", err)
 	}
 	defer func() {
 		if err := client.Close(); err != nil {