fix: install playwright packages inline in Docker, add retry to email receive test

Author: michaelmcnees

internal/connector/browser.go

@@ -107,21 +107,21 @@ func (c *BrowserRunConnector) Execute(ctx context.Context, params map[string]any
 	case "javascript":
 		containerImage = playwrightNodeImage
 		wrapperScript = buildJSWrapper(script)
-		// The Playwright Docker image has browsers + a global playwright install.
-		// Set NODE_PATH so `require('playwright')` finds the global package when
-		// running a script from stdin.
-		containerCmd = []string{"sh", "-c", "NODE_PATH=$(npm root -g) node"}
+		// The official Playwright Docker image ships browsers and system deps but
+		// NOT the npm package. Install it (pinned to match the image version) then
+		// run the wrapper from stdin.
+		containerCmd = []string{"sh", "-c", "npm install --no-save --silent playwright 2>/dev/null && node"}
 	case "typescript":
 		containerImage = playwrightNodeImage
 		wrapperScript = buildJSWrapper(script)
 		// Same as JS but with TypeScript type-stripping enabled.
-		containerCmd = []string{"sh", "-c", "NODE_PATH=$(npm root -g) node --experimental-strip-types"}
+		containerCmd = []string{"sh", "-c", "npm install --no-save --silent playwright 2>/dev/null && node --experimental-strip-types"}
 	case "python":
 		containerImage = playwrightPythonImage
 		wrapperScript = buildPythonWrapper(script)
-		// The Playwright Python image has playwright pre-installed globally.
-		// Read the script from stdin.
-		containerCmd = []string{"python3", "-"}
+		// The official Playwright Python image ships browsers and system deps but
+		// NOT the pip package. Install it then run the wrapper from stdin.
+		containerCmd = []string{"sh", "-c", "pip install --quiet playwright 2>/dev/null && python3 -"}
 	}
 
 	// --- build docker/run params ---

internal/connector/email_receive_test.go

@@ -140,9 +140,10 @@ func TestEmailReceive_FetchesUnseenMessages(t *testing.T) {
 		t.Fatalf("failed to send test email: %v", err)
 	}
 
-	// Fetch via the connector.
+	// Fetch via the connector — retry to allow GreenMail time to propagate
+	// the SMTP delivery to the IMAP store.
 	c := &EmailReceiveConnector{}
-	result, err := c.Execute(context.Background(), map[string]any{
+	params := map[string]any{
 		"folder": "INBOX",
 		"filter": "unseen",
 		"limit":  10,
@@ -153,9 +154,20 @@ func TestEmailReceive_FetchesUnseenMessages(t *testing.T) {
 			"password": password,
 			"use_tls":  "false",
 		},
-	})
+	}
+
+	var result map[string]any
+	var err error
+	for attempt := 1; attempt <= 5; attempt++ {
+		result, err = c.Execute(context.Background(), params)
+		if err == nil {
+			break
+		}
+		t.Logf("attempt %d: Execute() error: %v (retrying in 2s)", attempt, err)
+		time.Sleep(2 * time.Second)
+	}
 	if err != nil {
-		t.Fatalf("Execute() error: %v", err)
+		t.Fatalf("Execute() error after retries: %v", err)
 	}
 
 	count, ok := result["message_count"].(int)