Skip to content

Commit d2ec159

Browse files
committed
fix: address CodeRabbit review feedback from PR #122
- release-engine.yml: add docker/setup-qemu-action@v3 before Buildx to support multi-platform (ARM64) Docker builds; without QEMU, ARM64 RUN layers fail in buildx emulation - RELEASING.md: replace [the relevant issue] placeholder with actual link to #123 (rename release-please.yml to changeset-version.yml) https://claude.ai/code/session_01CuTGMFzUAdw5L5p5n9vEa5
1 parent 46f95c0 commit d2ec159

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/release-engine.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ jobs:
2929
username: ${{ github.actor }}
3030
password: ${{ secrets.GITHUB_TOKEN }}
3131

32+
- uses: docker/setup-qemu-action@v3
33+
3234
- uses: docker/setup-buildx-action@v3
3335

3436
- name: Set goreleaser tag

RELEASING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The automated CI path (Version PR → merge) requires no local tooling beyond gi
2828
5b. release-helm.yml → helm push OCI + GitHub Release
2929
```
3030

31-
> **Note on workflow naming:** `release-please.yml` is named after a tool we evaluated but didn't adopt — it actually runs the Changesets CLI. A rename to `changeset-version.yml` is tracked in [the relevant issue].
31+
> **Note on workflow naming:** `release-please.yml` is named after a tool we evaluated but didn't adopt — it actually runs the Changesets CLI. A rename to `changeset-version.yml` is tracked in [dvflw/mantle#123](https://github.com/dvflw/mantle/issues/123).
3232
3333
## Step 1: Add a Changeset (During Development)
3434

0 commit comments

Comments
 (0)