fix: address Copilot review feedback on PR #142

- Validate priority range (0–4) in linear/create_issue; return error early
- Replace duplicate extractIntParam with shared extractInt (handles int64)
- Rename shadowed body var to respBody in github/dispatch error path
- Add TestLinearCreateIssueConnector_InvalidPriority test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

packages/engine/internal/connector/github.go

@@ -167,8 +167,8 @@ func (c *GitHubDispatchConnector) Execute(ctx context.Context, params map[string
 
 	// GitHub returns 204 No Content on success.
 	if resp.StatusCode != http.StatusNoContent {
-		body, _ := io.ReadAll(io.LimitReader(resp.Body, 500))
-		return nil, fmt.Errorf("github/dispatch: GitHub API returned %d: %s", resp.StatusCode, truncate(string(body), 500))
+		respBody, _ := io.ReadAll(io.LimitReader(resp.Body, 500))
+		return nil, fmt.Errorf("github/dispatch: GitHub API returned %d: %s", resp.StatusCode, truncate(string(respBody), 500))
 	}
 
 	return map[string]any{"ok": true}, nil

packages/engine/internal/connector/linear.go

@@ -52,7 +52,10 @@ func (c *LinearCreateIssueConnector) Execute(ctx context.Context, params map[str
 	if projectID, ok := params["project_id"].(string); ok && projectID != "" {
 		input["projectId"] = projectID
 	}
-	if priority, ok := extractIntParam(params["priority"]); ok {
+	if priority, ok := extractInt(params["priority"]); ok {
+		if priority < 0 || priority > 4 {
+			return nil, fmt.Errorf("linear/create_issue: priority must be between 0 and 4, got %d", priority)
+		}
 		input["priority"] = priority
 	}
 	if labelIDs := toStringSlice(params["label_ids"]); len(labelIDs) > 0 {
@@ -117,7 +120,7 @@ func (c *LinearSearchConnector) Execute(ctx context.Context, params map[string]a
 	}
 
 	limit := 25
-	if l, ok := extractIntParam(params["limit"]); ok && l > 0 {
+	if l, ok := extractInt(params["limit"]); ok && l > 0 {
 		limit = l
 	}
 
@@ -235,13 +238,3 @@ func extractLinearToken(params map[string]any) (string, error) {
 	return token, nil
 }
 
-// extractIntParam extracts an integer from float64 (JSON default) or int.
-func extractIntParam(v any) (int, bool) {
-	switch n := v.(type) {
-	case int:
-		return n, true
-	case float64:
-		return int(n), true
-	}
-	return 0, false
-}

packages/engine/internal/connector/linear_test.go

@@ -103,6 +103,19 @@ func TestLinearCreateIssueConnector_MissingTitle(t *testing.T) {
 	}
 }
 
+func TestLinearCreateIssueConnector_InvalidPriority(t *testing.T) {
+	c := &LinearCreateIssueConnector{}
+	_, err := c.Execute(context.Background(), map[string]any{
+		"team_id":     "team-uuid",
+		"title":       "Test",
+		"priority":    float64(5),
+		"_credential": map[string]string{"token": "lin_api_test"},
+	})
+	if err == nil {
+		t.Fatal("expected error for priority out of range")
+	}
+}
+
 func TestLinearCreateIssueConnector_MissingCredential(t *testing.T) {
 	c := &LinearCreateIssueConnector{}
 	_, err := c.Execute(context.Background(), map[string]any{